Skip to content

Basic Schema Field Pruning #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
johannes-wolf wants to merge 3 commits into
base: main
Choose a base branch
from

Add Root Pruning Test

9bbff92
Select commit
Loading
Failed to load commit list.
Draft

Basic Schema Field Pruning #144

Add Root Pruning Test
9bbff92
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 9, 2026 in 49s

Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 165 in include/simfil/model/schema.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::unique" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq40aBOAiju0VkxLS&open=AZ4Nq40aBOAiju0VkxLS&pullRequest=144

Check warning on line 277 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused parameter "token", make it unnamed, or declare it "[[maybe_unused]]". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxK4&open=AZ4Nq4yVBOAiju0VkxK4&pullRequest=144

Check warning on line 96 in src/rewrite-rules.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "lhs" is "class simfil::WildcardExpr *". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4zSBOAiju0VkxLM&open=AZ4Nq4zSBOAiju0VkxLM&pullRequest=144

Check warning on line 779 in test/simfil.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4tiBOAiju0VkxKi&open=AZ4Nq4tiBOAiju0VkxKi&pullRequest=144

Check warning on line 160 in test/schema.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4vfBOAiju0VkxKo&open=AZ4Nq4vfBOAiju0VkxKo&pullRequest=144

Check failure on line 250 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::UnaryExpr<simfil::OperatorBool>::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxK-&open=AZ4Nq4yVBOAiju0VkxK-&pullRequest=144

Check failure on line 309 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::BinaryExpr::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxK3&open=AZ4Nq4yVBOAiju0VkxK3&pullRequest=144

Check warning on line 76 in include/simfil/expression.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq414BOAiju0VkxLY&open=AZ4Nq414BOAiju0VkxLY&pullRequest=144

Check warning on line 51 in src/simfil.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4xNBOAiju0VkxKq&open=AZ4Nq4xNBOAiju0VkxKq&pullRequest=144

Check failure on line 138 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::AnyExpr::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxKx&open=AZ4Nq4yVBOAiju0VkxKx&pullRequest=144

Check failure on line 250 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::UnaryExpr<simfil::OperatorAsString>::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxLB&open=AZ4Nq4yVBOAiju0VkxLB&pullRequest=144

Check warning on line 59 in src/rewrite-rules.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "rhs" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4zSBOAiju0VkxLF&open=AZ4Nq4zSBOAiju0VkxLF&pullRequest=144

Check failure on line 512 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::OrExpr::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxK9&open=AZ4Nq4yVBOAiju0VkxK9&pullRequest=144

Check warning on line 41 in src/rewrite-rules.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a reference-to-const. The current type of "expr" is "class std::unique_ptr<class simfil::Expr> &". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4zSBOAiju0VkxLD&open=AZ4Nq4zSBOAiju0VkxLD&pullRequest=144

Check warning on line 93 in src/rewrite-rules.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a reference-to-const. The current type of "expr" is "class std::unique_ptr<class simfil::Expr> &". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4zSBOAiju0VkxLK&open=AZ4Nq4zSBOAiju0VkxLK&pullRequest=144

Check warning on line 158 in include/simfil/model/schema.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "canFinalize" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq40aBOAiju0VkxLP&open=AZ4Nq40aBOAiju0VkxLP&pullRequest=144

Check failure on line 250 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::UnaryExpr<simfil::OperatorAsInt>::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxK_&open=AZ4Nq4yVBOAiju0VkxK_&pullRequest=144

Check failure on line 106 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::SubscriptExpr::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxKv&open=AZ4Nq4yVBOAiju0VkxKv&pullRequest=144

Check warning on line 224 in include/simfil/model/schema.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "simfil::Schema::State". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq40aBOAiju0VkxLV&open=AZ4Nq40aBOAiju0VkxLV&pullRequest=144

Check warning on line 206 in include/simfil/model/schema.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::lower_bound" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq40aBOAiju0VkxLT&open=AZ4Nq40aBOAiju0VkxLT&pullRequest=144

Check failure on line 250 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::UnaryExpr::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxK2&open=AZ4Nq4yVBOAiju0VkxK2&pullRequest=144

Check failure on line 123 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::SubExpr::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxKw&open=AZ4Nq4yVBOAiju0VkxKw&pullRequest=144

Check warning on line 82 in src/rewrite-rules.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "lhsRhs" is "class simfil::WildcardExpr *". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4zSBOAiju0VkxLJ&open=AZ4Nq4zSBOAiju0VkxLJ&pullRequest=144

Check warning on line 54 in src/rewrite-rules.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a reference-to-const. The current type of "expr" is "class std::unique_ptr<class simfil::Expr> &". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4zSBOAiju0VkxLE&open=AZ4Nq4zSBOAiju0VkxLE&pullRequest=144

Check failure on line 169 in src/expressions.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Correct these functions so that no function in "simfil::CallExpression::childAt" hides a function in "simfil::Expr::childAt". 

See more on https://sonarcloud.io/project/issues?id=Klebert-Engineering_simfil&issues=AZ4Nq4yVBOAiju0VkxKz&open=AZ4Nq4yVBOAiju0VkxKz&pullRequest=144
View more details on SonarQubeCloud