Fix locales + add strings in bundle#1
Open
etabard wants to merge 3 commits intoKiranPanesar:masterfrom
etabard:fix-locales
Open
Fix locales + add strings in bundle#1etabard wants to merge 3 commits intoKiranPanesar:masterfrom etabard:fix-locales
etabard wants to merge 3 commits intoKiranPanesar:masterfrom
etabard:fix-locales
Conversation
Author
|
I wanted to separate pull requests but it'd complicate merge. I added code to honor constants options.
|
etabard
pushed a commit
to etabard/Cordova-PDFReader-IOS
that referenced
this pull request
May 27, 2014
|
up! Would like to see this pull request considered for merging |
Owner
|
Hi @etabard. Thanks for the PR! Sorry it's taken me over 6 months to get to it! Can you merge master back into yours and submit again. I'll gladly review and merge. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You seems to have the most maintained version of Reader. If it's ok with you, I moved strings files in the Reader.bundle and localized all strings.
Let me know if something's wrong / missing.