[pull] master from getsentry:master

.github/CODEOWNERS

@@ -586,6 +586,7 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /static/app/gettingStartedDocs/                                                  @getsentry/value-discovery
 /static/app/types/project.tsx                                                    @getsentry/value-discovery
 /static/app/views/onboarding/                                                    @getsentry/value-discovery
+/tests/js/fixtures/detectedPlatform.ts                                           @getsentry/value-discovery
 /static/app/views/projectInstall/                                                @getsentry/value-discovery
 /src/sentry/onboarding_tasks/                                                    @getsentry/value-discovery
 ## End of Value Discovery
@@ -597,6 +598,8 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /tests/sentry/seer/                                         @getsentry/machine-learning-ai
 /src/sentry/seer/fetch_issues/                              @getsentry/machine-learning-ai @getsentry/coding-workflows-sentry-backend
 /tests/sentry/seer/fetch_issues/                            @getsentry/machine-learning-ai @getsentry/coding-workflows-sentry-backend
+/src/sentry/tasks/seer/                                     @getsentry/machine-learning-ai
+/tests/sentry/tasks/seer/                                   @getsentry/machine-learning-ai
 ## End of ML & AI
 
 ## Issues
@@ -647,7 +650,7 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /src/sentry/tasks/clear_expired_snoozes.py                  @getsentry/issue-detection-backend
 /src/sentry/tasks/codeowners/                               @getsentry/issue-detection-backend
 /src/sentry/tasks/commit_context.py                         @getsentry/issue-detection-backend
-/src/sentry/tasks/delete_seer_grouping_records.py           @getsentry/issue-detection-backend
+/src/sentry/tasks/seer/delete_seer_grouping_records.py      @getsentry/issue-detection-backend
 /src/sentry/tasks/embeddings_grouping/                      @getsentry/issue-detection-backend
 /src/sentry/tasks/groupowner.py                             @getsentry/issue-detection-backend
 /src/sentry/tasks/merge.py                                  @getsentry/issue-detection-backend
@@ -658,6 +661,7 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /static/app/components/events/eventTags/                    @getsentry/issue-workflow
 /static/app/components/events/highlights/                   @getsentry/issue-workflow
 /static/app/components/issues/                              @getsentry/issue-workflow
+/static/app/components/stackTrace/                          @getsentry/issue-workflow
 /static/app/views/issueList/                                @getsentry/issue-workflow
 /static/app/views/issueList/pages/supergroups.tsx           @getsentry/issue-detection-frontend
 /static/app/views/issueList/supergroups/                    @getsentry/issue-detection-frontend
@@ -685,14 +689,13 @@ tests/sentry/api/endpoints/test_organization_attribute_mappings.py          @get
 /tests/sentry/tasks/test_auto_ongoing_issues.py             @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_auto_remove_inbox.py               @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_auto_resolve_issues.py             @getsentry/issue-detection-backend
-/tests/sentry/tasks/test_backfill_seer_grouping_records.py  @getsentry/issue-detection-backend
+/tests/sentry/tasks/seer/test_delete_seer_grouping_records.py @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_check_new_issue_threshold_met.py   @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_clear_expired_resolutions.py       @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_clear_expired_rulesnoozes.py       @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_clear_expired_snoozes.py           @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_code_owners.py                     @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_commit_context.py                  @getsentry/issue-detection-backend
-/tests/sentry/tasks/test_delete_seer_grouping_records.py    @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_groupowner.py                      @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_merge.py                           @getsentry/issue-detection-backend
 /tests/sentry/tasks/test_post_process.py                    @getsentry/issue-detection-backend

.github/codeowners-coverage-baseline.txt

@@ -869,7 +869,6 @@ static/app/components/modals/explore/saveQueryModal.spec.tsx
 static/app/components/modals/explore/saveQueryModal.tsx
 static/app/components/modals/featureTourModal.spec.tsx
 static/app/components/modals/featureTourModal.tsx
-static/app/components/modals/generateDashboardFromSeerModal.tsx
 static/app/components/modals/helpSearchModal.spec.tsx
 static/app/components/modals/helpSearchModal.tsx
 static/app/components/modals/importDashboardFromFileModal.tsx
@@ -1071,7 +1070,6 @@ static/app/components/repositories/scmIntegrationTree/useScmTreeFilters.tsx
 static/app/components/repositories/scmRepoTreeModal.tsx
 static/app/components/repositoryRow.spec.tsx
 static/app/components/repositoryRow.tsx
-static/app/components/reprocessedBox.tsx
 static/app/components/resolutionBox.spec.tsx
 static/app/components/resolutionBox.tsx
 static/app/components/resourceCard.tsx
@@ -2524,14 +2522,12 @@ tests/sentry/tasks/test_activity.py
 tests/sentry/tasks/test_assemble.py
 tests/sentry/tasks/test_auth.py
 tests/sentry/tasks/test_auto_enable_codecov.py
-tests/sentry/tasks/test_autofix.py
 tests/sentry/tasks/test_base.py
 tests/sentry/tasks/test_beacon.py
 tests/sentry/tasks/test_check_am2_compatibility.py
 tests/sentry/tasks/test_check_auth.py
 tests/sentry/tasks/test_collect_project_platforms.py
 tests/sentry/tasks/test_commits.py
-tests/sentry/tasks/test_context_engine_index.py
 tests/sentry/tasks/test_delete_pending_groups.py
 tests/sentry/tasks/test_digests.py
 tests/sentry/tasks/test_email.py
@@ -2541,8 +2537,6 @@ tests/sentry/tasks/test_organization_contributors.py
 tests/sentry/tasks/test_process_buffer.py
 tests/sentry/tasks/test_relay.py
 tests/sentry/tasks/test_reprocessing2.py
-tests/sentry/tasks/test_seer.py
-tests/sentry/tasks/test_seer_explorer_index.py
 tests/sentry/tasks/test_store.py
 tests/sentry/tasks/test_symbolication.py
 tests/sentry/tasks/test_update_code_owners_schema.py

pyproject.toml

@@ -84,7 +84,7 @@ dependencies = [
   "sentry-arroyo>=2.38.1",
   "sentry-conventions>=0.3.0",
   "sentry-forked-email-reply-parser>=0.5.12.post1",
-  "sentry-kafka-schemas>=2.1.26",
+  "sentry-kafka-schemas>=2.1.27",
   "sentry-ophio>=1.1.3",
   "sentry-protos>=0.8.7",
   "sentry-redis-tools>=0.5.0",
@@ -676,9 +676,9 @@ module = [
   "sentry.tasks.beacon",
   "sentry.tasks.codeowners.*",
   "sentry.tasks.commit_context",
-  "sentry.tasks.delete_seer_grouping_records",
   "sentry.tasks.on_demand_metrics",
   "sentry.tasks.reprocessing2",
+  "sentry.tasks.seer.delete_seer_grouping_records",
   "sentry.tasks.store",
   "sentry.tasks.unmerge",
   "sentry.taskworker.*",
@@ -888,8 +888,8 @@ module = [
   "tests.sentry.snuba.test_tasks",
   "tests.sentry.spans.grouping.*",
   "tests.sentry.tasks.integrations.*",
+  "tests.sentry.tasks.seer.test_delete_seer_grouping_records",
   "tests.sentry.tasks.test_code_owners",
-  "tests.sentry.tasks.test_delete_seer_grouping_records",
   "tests.sentry.tasks.test_on_demand_metrics",
   "tests.sentry.tempest.*",
   "tests.sentry.templatetags.*",

setup.cfg

@@ -88,6 +88,8 @@ sentry =
 # All other linting (E, W, F, B, LOG, I) is handled by ruff.
 # See [tool.ruff] in pyproject.toml for the main linting configuration.
 select = S
+# S016 is temporarily disabled until the ThreadPoolExecutor migration is complete.
+extend-ignore = S016
 per-file-ignores =
     # these scripts must have minimal dependencies so opt out of the usual sentry rules
     .github/*: S

src/sentry/api/endpoints/organization_events_trends_v2.py

@@ -8,7 +8,6 @@
 from rest_framework.response import Response
 from snuba_sdk import Column
 
-from sentry import features
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import cell_silo_endpoint
 from sentry.api.bases import NoProjects, OrganizationEventsEndpointBase
@@ -69,15 +68,7 @@ class OrganizationEventsNewTrendsStatsEndpoint(OrganizationEventsEndpointBase):
         }
     )
 
-    def has_feature(self, organization, request):
-        return features.has(
-            "organizations:performance-new-trends", organization, actor=request.user
-        )
-
     def get(self, request: Request, organization: Organization) -> Response:
-        if not self.has_feature(organization, request):
-            return Response(status=404)
-
         viewer_context = SeerViewerContext(organization_id=organization.id, user_id=request.user.id)
 
         try:

src/sentry/api/endpoints/organization_plugin_deprecation_info.py

@@ -62,7 +62,7 @@ def get_plugin_rules_urls(
                     and action.get("service") == plugin
                 ):
                     matching_rule_urls.append(
-                        f"{url_prefix}/alerts/rules/{rule.project.slug}/{rule.id}/details/"
+                        f"{url_prefix}/issues/alerts/rules/{rule.project.slug}/{rule.id}/details/"
                     )
                     break
         return matching_rule_urls

src/sentry/conf/server.py

@@ -539,6 +539,9 @@ def env(
 CSP_FRAME_ANCESTORS = [
     "'none'",
 ]
+CSP_FRAME_SRC = [
+    "demo.arcade.software",
+]
 CSP_OBJECT_SRC = [
     "'none'",
 ]
@@ -867,6 +870,7 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "sentry.integrations.github.tasks.codecov_account_unlink",
     "sentry.integrations.github.tasks.link_all_repos",
     "sentry.integrations.github.tasks.pr_comment",
+    "sentry.integrations.gitlab.tasks",
     "sentry.integrations.jira.tasks",
     "sentry.integrations.opsgenie.tasks",
     "sentry.integrations.slack.tasks.find_channel_id_for_alert_rule",
@@ -922,7 +926,7 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "sentry.tasks.auto_remove_inbox",
     "sentry.tasks.auto_resolve_issues",
     "sentry.tasks.auto_source_code_config",
-    "sentry.tasks.autofix",
+    "sentry.tasks.seer.autofix",
     "sentry.tasks.beacon",
     "sentry.tasks.check_am2_compatibility",
     "sentry.tasks.clear_expired_resolutions",
@@ -934,7 +938,7 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "sentry.tasks.commit_context",
     "sentry.tasks.commits",
     "sentry.tasks.delete_pending_groups",
-    "sentry.tasks.delete_seer_grouping_records",
+    "sentry.tasks.seer.delete_seer_grouping_records",
     "sentry.tasks.digests",
     "sentry.tasks.email",
     "sentry.tasks.files",
@@ -954,7 +958,7 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "sentry.tasks.repository",
     "sentry.tasks.reprocessing2",
     "sentry.tasks.scim.privilege_sync",
-    "sentry.tasks.seer",
+    "sentry.tasks.seer.cleanup",
     "sentry.tasks.statistical_detectors",
     "sentry.tasks.store",
     "sentry.tasks.summaries.weekly_reports",
@@ -972,8 +976,8 @@ def SOCIAL_AUTH_DEFAULT_USERNAME() -> str:
     "sentry.workflow_engine.tasks.delayed_workflows",
     "sentry.workflow_engine.tasks.workflows",
     "sentry.workflow_engine.tasks.actions",
-    "sentry.tasks.seer_explorer_index",
-    "sentry.tasks.context_engine_index",
+    "sentry.tasks.seer.explorer_index",
+    "sentry.tasks.seer.context_engine_index",
     # Used for tests
     "sentry.taskworker.tasks.examples",
 )
@@ -1412,7 +1416,6 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
 # Sentry and internal client configuration
 
 SENTRY_EARLY_FEATURES = {
-    "organizations:performance-new-trends": "Enable new trends",
     "organizations:performance-new-widget-designs": "Enable updated landing page widget designs",
     "organizations:profiling-global-suspect-functions": "Enable global suspect functions in profiling",
 }
@@ -2692,6 +2695,8 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
     "taskworker-internal-dlq": "default",
     "taskworker-limited": "default",
     "taskworker-limited-dlq": "default",
+    "taskworker-launchpad": "default",
+    "taskworker-launchpad-dlq": "default",
     "taskworker-long": "default",
     "taskworker-long-dlq": "default",
     "taskworker-products": "default",

src/sentry/conf/types/cell_config.py

@@ -16,4 +16,5 @@ class LocalityConfig(TypedDict):
     name: str
     category: str
     cells: list[str]
+    new_org_cell: str
     visible: NotRequired[bool]

src/sentry/conf/types/kafka_definition.py

@@ -96,6 +96,8 @@ class Topic(Enum):
     TASKWORKER_INGEST_PROFILING_DLQ = "taskworker-ingest-profiling-dlq"
     TASKWORKER_INTERNAL = "taskworker-internal"
     TASKWORKER_INTERNAL_DLQ = "taskworker-internal-dlq"
+    TASKWORKER_LAUNCHPAD = "taskworker-launchpad"
+    TASKWORKER_LAUNCHPAD_DLQ = "taskworker-launchpad-dlq"
     TASKWORKER_LIMITED = "taskworker-limited"
     TASKWORKER_LIMITED_DLQ = "taskworker-limited-dlq"
     TASKWORKER_LONG = "taskworker-long"

src/sentry/core/endpoints/project_details.py

@@ -57,7 +57,7 @@
 from sentry.notifications.utils import has_alert_integration
 from sentry.relay.datascrubbing import validate_pii_config_update, validate_pii_selectors
 from sentry.seer.autofix.constants import AutofixAutomationTuningSettings
-from sentry.tasks.delete_seer_grouping_records import call_seer_delete_project_grouping_records
+from sentry.tasks.seer.delete_seer_grouping_records import call_seer_delete_project_grouping_records
 from sentry.tempest.utils import has_tempest_access
 
 logger = logging.getLogger(__name__)

src/sentry/dashboards/models/generate_dashboard_artifact.py

@@ -72,6 +72,8 @@ def check_blocklist(cls, v: str) -> str:
 
 
 class GeneratedWidgetLayout(BaseModel):
+    """Layout position and size on a 6-column grid. Widget widths in each row should sum to 6 to fill the grid completely."""
+
     x: int = Field(
         default=0,
         description=f"Column position (0-{GRID_WIDTH - 1}). x + w must not exceed {GRID_WIDTH}.",
@@ -115,18 +117,25 @@ def fit_within_grid(cls, w: int, values: dict[str, Any]) -> int:
 
 
 class GeneratedWidget(BaseModel):
+    """A single dashboard widget. Default sizes by display type: big_number 2w x 1h (3 per row), line/area/bar/stacked_area/top_n 3w x 2h (2 per row), table 6w x 2h (full row)."""
+
     title: str = Field(..., max_length=255)  # Matches serializer
     description: str = Field(
         ..., max_length=255
     )  # Length matches serializer, required field for generation
     display_type: DisplayType
-    widget_type: WidgetType
+    widget_type: WidgetType = Field(
+        ...,
+        description="Dataset to query. Use 'spans' as the default — it covers most use cases. Use 'error-events' for error-specific data, 'issue' for issue tracking, 'logs' for log data, 'tracemetrics' for trace metrics.",
+    )
     queries: list[GeneratedWidgetQuery]
     layout: GeneratedWidgetLayout
     limit: int | None = Field(default=None, le=10, ge=1)
     interval: Intervals = Field(default="1h")
 
 
 class GeneratedDashboard(BaseModel):
+    """A complete dashboard definition on a 6-column grid. Widget widths per row must sum to 6. This is the sole output artifact."""
+
     title: str = Field(..., max_length=255)  # Matches serializer
     widgets: list[GeneratedWidget] = Field(..., max_items=Dashboard.MAX_WIDGETS)

src/sentry/deletions/defaults/group.py

@@ -30,7 +30,9 @@
 from sentry.notifications.models.notificationmessage import NotificationMessage
 from sentry.services.eventstore.models import Event
 from sentry.snuba.dataset import Dataset
-from sentry.tasks.delete_seer_grouping_records import may_schedule_task_to_delete_hashes_from_seer
+from sentry.tasks.seer.delete_seer_grouping_records import (
+    may_schedule_task_to_delete_hashes_from_seer,
+)
 from sentry.utils import metrics
 
 from ..base import BaseDeletionTask, BaseRelation, ModelDeletionTask, ModelRelation

src/sentry/features/temporary.py

@@ -198,8 +198,6 @@ def register_temporary_features(manager: FeatureManager) -> None:
     manager.add("organizations:performance-mep-bannerless-ui", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Re-enable histograms for Metrics Enhanced Performance Views
     manager.add("organizations:performance-mep-reintroduce-histograms", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
-    # Enable new trends
-    manager.add("organizations:performance-new-trends", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable updated landing page widget designs
     manager.add("organizations:performance-new-widget-designs", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable MongoDB support for the Queries module

src/sentry/hybridcloud/services/control_organization_provisioning/model.py

@@ -1,3 +1,7 @@
+from typing import Any
+
+from pydantic import root_validator
+
 from sentry.hybridcloud.rpc import RpcModel
 
 
@@ -8,3 +12,14 @@ class RpcOrganizationSlugReservation(RpcModel):
     slug: str
     region_name: str
     reservation_type: int
+
+    @root_validator(pre=True)
+    @classmethod
+    def _accept_cell_name(cls, values: dict[str, Any]) -> dict[str, Any]:
+        if "cell_name" in values and "region_name" not in values:
+            values["region_name"] = values.pop("cell_name")
+        return values
+
+    @property
+    def cell_name(self) -> str:
+        return self.region_name

src/sentry/incidents/endpoints/bases.py

@@ -106,6 +106,53 @@ def convert_args(
         return args, kwargs
 
 
+class WorkflowEngineProjectAlertRuleEndpoint(ProjectAlertRuleEndpoint):
+    def convert_args(
+        self, request: Request, alert_rule_id: int, *args: Any, **kwargs: Any
+    ) -> tuple[tuple[Any, ...], dict[str, Any]]:
+        args, kwargs = super(ProjectAlertRuleEndpoint, self).convert_args(request, *args, **kwargs)
+        project = kwargs["project"]
+        validated_alert_rule_id = to_valid_int_id("alert_rule_id", alert_rule_id, raise_404=True)
+
+        # Allow orgs that have downgraded plans to delete metric alerts
+        if request.method != "DELETE" and not features.has(
+            "organizations:incidents", project.organization, actor=request.user
+        ):
+            raise ResourceDoesNotExist
+
+        if not request.access.has_project_access(project):
+            raise PermissionDenied
+
+        if features.has("organizations:workflow-engine-rule-serializers", project.organization):
+            try:
+                ard = AlertRuleDetector.objects.get(
+                    alert_rule_id=validated_alert_rule_id,
+                    detector__project=project,
+                )
+                kwargs["alert_rule"] = ard.detector
+            except AlertRuleDetector.DoesNotExist:
+                # XXX: this means the detector was single written and has no ARD or related AlertRule object
+                try:
+                    detector_id = get_object_id_from_fake_id(validated_alert_rule_id)
+                    kwargs["alert_rule"] = Detector.objects.get(
+                        id=detector_id,
+                        project=project,
+                    )
+                except Detector.DoesNotExist:
+                    raise ResourceDoesNotExist
+
+            return args, kwargs
+
+        try:
+            kwargs["alert_rule"] = AlertRule.objects.get(
+                projects=project, id=validated_alert_rule_id
+            )
+        except AlertRule.DoesNotExist:
+            raise ResourceDoesNotExist
+
+        return args, kwargs
+
+
 class WorkflowEngineOrganizationAlertRuleEndpoint(OrganizationAlertRuleEndpoint):
     def convert_args(
         self, request: Request, alert_rule_id: int, *args: Any, **kwargs: Any