fix(vscode): add back button to profile view header#599
fix(vscode): add back button to profile view header#599Olusammytee wants to merge 2 commits intoKilo-Org:devfrom
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
| <h2 style={{ "font-size": "16px", "font-weight": "600", margin: 0 }}>{language.t("profile.title")}</h2> | ||
| </div> | ||
| <div style={{ padding: "16px" }}> | ||
| <Show |
There was a problem hiding this comment.
[SUGGESTION]: Indentation is off — <Show> (and its children through line 266) is now nested inside the <div style={{ padding: "16px" }}> wrapper on line 119, but it's not indented to reflect that. The closing </Show> on line 266 and </div> on line 267 have the same issue. This makes the JSX tree structure harder to follow.
| <Show | |
| <Show |
Code Review SummaryStatus: No New Issues Found | Recommendation: Merge (after addressing existing feedback) OverviewThis PR adds a back button to the Profile view header, following the same UX pattern already established in the Settings component. The implementation is clean and consistent:
Existing feedback from other reviewers (indentation + overflow handling) should still be addressed before merge. Files Reviewed (2 files)
|
There was a problem hiding this comment.
Pull request overview
This PR restores navigational parity between the Profile and Settings views in the VS Code webview UI by adding a header back button to Profile and wiring it to return users to the chat view.
Changes:
- Add a Settings-like header (with back button) to
ProfileView. - Extend
ProfileViewprops with an optionalonBackcallback and invoke it from the new back button. - Wire Profile back navigation in
AppContentto return to the"newTask"(chat) view.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/kilo-vscode/webview-ui/src/components/ProfileView.tsx | Adds a header with back button and wraps existing profile content under a new layout container. |
| packages/kilo-vscode/webview-ui/src/App.tsx | Passes an onBack handler to ProfileView that navigates back to chat ("newTask"). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </Tooltip> | ||
| <h2 style={{ "font-size": "16px", "font-weight": "600", margin: 0 }}>{language.t("profile.title")}</h2> | ||
| </div> | ||
| <div style={{ padding: "16px" }}> |
There was a problem hiding this comment.
Because the root is a fixed-height flex column (height: "100%") and the webview .container uses overflow: hidden, the content wrapper needs to participate in flex layout (and typically scroll) or long profile content can be clipped with no way to scroll. Consider giving the content <div> flex: 1, min-height: 0, and overflow-y: auto (or similar), matching how other full-height views manage overflow.
| <div style={{ padding: "16px" }}> | |
| <div | |
| style={{ | |
| padding: "16px", | |
| display: "flex", | |
| "flex-direction": "column", | |
| flex: 1, | |
| "min-height": 0, | |
| "overflow-y": "auto", | |
| }} | |
| > |
| <div style={{ padding: "16px" }}> | ||
| <Show | ||
| when={props.profileData} |
There was a problem hiding this comment.
The <Show> block is not indented under the new padded content wrapper, which makes the JSX structure harder to read and can trip formatting checks. Running Prettier (or adjusting indentation) would keep this consistent with the rest of the codebase.
|
Updated the PR description to include an explicit linked issue reference: Closes #568. |
|
Addressed the formatting suggestion by aligning indentation for the Show block inside the padded content wrapper (commit �d5b340). |
Linked Issue\nCloses #568\n\n## Summary\n- add a back button to the Profile view header using the same UX pattern as Settings\n- wire Profile view back action to return users to the chat view\n- keep existing profile content unchanged\n\n## Testing\n- unable to run package checks in this environment (bun not installed)