Add start menu shortcut and launch upon install#2
Open
andrewdbond wants to merge 2 commits intoKeypirinha:masterfrom
Open
Add start menu shortcut and launch upon install#2andrewdbond wants to merge 2 commits intoKeypirinha:masterfrom
andrewdbond wants to merge 2 commits intoKeypirinha:masterfrom
Conversation
Including because Chocolatey installs Keypirinha to a location isn’t immediately obvious to most users, upon installation add a start menu shortcut and launch Keypirinha. Tweak PowerShell parameter names and capitalization to match PowerShell documentation defaults.
ghost
mentioned this pull request
Member
|
Thanks for this! :) Just a tiny thing before merging, as described in the README file, Please revert changes to |
I'm unaware of what internal build tools are used to generate the /build/ directory from the /src/**.in files. However, to test my changes I had to manually edit the /build/ files anyway. I understood that /build/ files are overwritten during the release process. However, as I was confident my files would match what the tool creates, I left them in the previous commit. Per the software owner's request, I'm reverting the /build/ changes. The /src/ changes remain.
Author
|
Thanks. As I'm unaware of the tools used to create |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including because Chocolatey installs Keypirinha to a location
isn’t immediately obvious to most users, upon installation add a start
menu shortcut and launch Keypirinha. With this, Keypirinha's Chocolatey installation would also function more like other traditional (Chocolatey) installed software which starts needed background process(es).
Tweak PowerShell parameter names and capitalization to match PowerShell
documentation defaults.
The package version hasn't yet been bumped. If a new package version is released without a new version of the underlying software, https://chocolatey.org/courses/creating-chocolatey-packages/naming-description-and-versioning#package-versioning recommends adding a ".YYYYMMDD" suffix to the package version.