Skip to content

Replace Invoke-Expression with Invoke-Item#102

Open
danhje wants to merge 1 commit intoKevinMarquette:masterfrom
danhje:patch-1
Open

Replace Invoke-Expression with Invoke-Item#102
danhje wants to merge 1 commit intoKevinMarquette:masterfrom
danhje:patch-1

Conversation

@danhje
Copy link

@danhje danhje commented Feb 3, 2020

Invoke-Expression gave error on certain versions of PowerShell. Invoke-Item is a better way of opening a file using the default program or action.

Invoke-Expression gave error on certain versions of PowerShell. Invoke-Item is a better way of opening a file using the default program or action.
@KevinMarquette
Copy link
Owner

Thank you for your patience, not sure how I missed this one.

Good call on using Invoke-Item instead. Code looks good as it is, I just need to test it. I don't think I have any tests for that line, so I may add one with a mock before merging.

@claw0ry
Copy link

claw0ry commented May 31, 2021

Hey, @KevinMarquette!

Have you had time to take a look at this?

@claudio-salvio
Copy link

Hi @KevinMarquette

I think it would be a good change.
I am writing as a reminder.
If you would be so kind as to spend some time on it, we would appreciate it.

🙏Thank you for making this very useful module available.

Best regards
Claudio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants