Handle tokens with invalid decimal places better#17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves robustness of token metadata parsing in the web explorer by normalizing decimalPlaces values derived from token metadata, preventing invalid values from propagating into token formatting/rendering.
Changes:
- Refactors
parseTokenMetadatato use a single defaultdecimalPlacesvalue and return it consistently. - Sanitizes parsed
decimalPlacesto coerce invalid numeric values (e.g.,NaN, negatives) back to0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rkeene
added a commit
to KeetaNetwork/anchor
that referenced
this pull request
May 10, 2026
This change improves the robustness of parsing token metadata decimals to match what the explorer does now (KeetaNetwork/explorer#17)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with the explorer handling of
decimalPlaceswhich are not a number, and just converts them silently to 0.