Improve PostgreSQL Queue Driver#300
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PostgreSQL-backed queue storage driver to reduce contention and serialization failures during concurrent add() operations by making inserts idempotent at the database level and running transactions at a less strict isolation level.
Changes:
- Switches queue operation transactions from
SERIALIZABLEtoREAD COMMITTED. - Refactors
add()to useINSERT ... ON CONFLICT DO NOTHING ... RETURNINGfor atomic existence checks and bulk idempotent-key insertion viaunnest(...). - Slightly restructures retry handling to more explicitly detect retryable PostgreSQL error codes (serialization/deadlock).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the PostgreSQL queue driver to not require the serializable isolation level by performing an atomic update-and-check when adding instead of splitting that into multiple queries would could cause insert conflicts when competing adds were performed concurrently. This should greatly improve the performance of the driver since there will be far fewer serialization errors.