Add KeetaNetCombinedAnchorHTTPServer to merge routes from multiple servers by Copilot · Pull Request #267 · KeetaNetwork/anchor

Copilot · 2026-04-16T21:40:36Z

Modify url getter to allow reading a statically-set URL (string/URL instance) even when the server is not started
Remove pre-existing // @ts-ignore in constructor by changing #url / url setter from polymorphic this callback type to explicit KeetaNetAnchorHTTPServer callback type
Add protected get config() to KeetaNetAnchorHTTPServer so subclasses have a single source of truth
Add protected buildRoutes() method to KeetaNetAnchorHTTPServer (delegates to initRoutes(this.#config))
Add KeetaAnchorCombinedHTTPServerConfig interface
Add KeetaNetCombinedAnchorHTTPServer class:
- No #children field — uses this.config.servers (single source of truth via protected getter)
- initRoutes uses config.servers parameter
- start() uses this.config.servers for URL propagation
- start() validates that any child with a pre-set URL matches the combined server's URL, re-throwing unknown errors from the URL getter
Add tests: combining routes, 404 for missing routes, conflict resolution (later child wins), URL propagation, conflicting child URL throws

…le servers Agent-Logs-Url: https://github.com/KeetaNetwork/anchor/sessions/adb8fb18-e173-4efe-b121-250f7a36612b Co-authored-by: ezraripps <19670988+ezraripps@users.noreply.github.com>

ezraripps · 2026-04-17T22:05:29Z

+	/**
+	 * Static helper that allows KeetaNetCombinedAnchorHTTPServer (and other
+	 * subclasses) to invoke buildRoutes() on an arbitrary
+	 * KeetaNetAnchorHTTPServer instance.  Protected access is valid here
+	 * because we are inside the KeetaNetAnchorHTTPServer class body.
+	 */
+	protected static callBuildRoutes(server: KeetaNetAnchorHTTPServer): Promise<Routes> {
+		return(server.buildRoutes());
+	}


This method should not be needed, if it is needed for testing you can access via server'buildRoutes' in tests as TS allows bypassing private flag that way, or by creating a class that overrides that method.

Removed callBuildRoutes. initRoutes now calls buildRoutes() via bracket notation directly on each child: (child as unknown as { buildRoutes(): Promise<Routes> }).buildRoutes() (ac464cb).

ezraripps · 2026-04-17T22:05:58Z

+
+	constructor(config: KeetaAnchorCombinedHTTPServerConfig) {
+		super(config);
+		this.#children = [...config.servers];


Why set this here then ignore it in initRoutes, it should probably just be used in initRoutes, if not we need to verify that both values are the same

Fixed in ac464cb — initRoutes now uses the config parameter directly (config.servers) instead of this.#children. The #children field is kept only for the start() override where the base class's private #config isn't accessible.

We should figure out a better way than having two sources of truth

Fixed in 3973da7. Added protected get config(): ConfigType to the base class and removed the #children field entirely. Both initRoutes and start() now read from this.config.servers — one source of truth.

Fixed in 3973da7 — removed #children and added protected get config() on the base class. Both initRoutes and start() now use this.config.servers.

ezraripps · 2026-04-17T22:06:29Z

+		 */
+		const url = this.url;
+		for (const child of this.#children) {
+			child.url = url;


What if the child already has a URL set? We should ensure they either do not or it is the same.

Added validation in ac464cb. Before propagating the URL, start() now tries to read each child's existing URL. If the child already has a static URL set and it differs from the combined server's URL, it throws: Error: Child server url "..." does not match combined server url "...". A test for this case is also added.

ezraripps · 2026-04-17T22:06:49Z

+		await super.start();
+
+		/*
+		 * Propagate the combined server's URL to all child server


Should we perform this validation here, or somewhere else?

Validation happens in start() after super.start() — that's the earliest point where the combined server's URL is known (it depends on the port assigned by the OS when no static URL is configured). For the common case of a static string/URL config, we could check earlier, but doing it uniformly in start() keeps the logic in one place.

ezraripps · 2026-04-17T22:07:12Z

+	protected buildRoutes(): Promise<Routes> {
+		return(this.initRoutes(this.#config));
+	}


Why have a method that overrides initRoutes? It does the same thing

buildRoutes() is a protected proxy that packages initRoutes(this.#config) into a no-argument call. It's needed because initRoutes is generic over ConfigType — you can't call it on an arbitrary child instance from outside the class without knowing (or storing) its config type. The method allows KeetaNetCombinedAnchorHTTPServer to invoke the correct initRoutes on each child via bracket notation without a cast that loses type information.

…utes, validate child URLs Agent-Logs-Url: https://github.com/KeetaNetwork/anchor/sessions/f2463b59-588b-4959-99c0-b9e5ac7293c2 Co-authored-by: ezraripps <19670988+ezraripps@users.noreply.github.com>

ezraripps · 2026-04-17T22:57:30Z

-		const retval = urlObj.toString();
-
-		return(retval);
+		return(urlObj.toString());


Why did this change?

These were incidental style cleanups made during the URL getter restructuring (inlining const retval = ...). Reverted in 3973da7 to keep the diff focused on the functional change.

ezraripps · 2026-04-17T22:57:36Z

 			newURLObj.search = '';

-			const retval = newURLObj.toString();
+			return(newURLObj.toString());


Why did this change?

Same as above — incidental style change, reverted in 3973da7.

ezraripps · 2026-04-17T22:59:07Z

+
+	constructor(config: KeetaAnchorCombinedHTTPServerConfig) {
+		super(config);
+		this.#children = [...config.servers];


We should figure out a better way than having two sources of truth

ezraripps · 2026-04-17T22:59:44Z

+			try {
+				childURL = child.url;
+			} catch {
+				/* child has no static URL set; the URL will be propagated below */


Why would this throw? If it does, should we check the specific error and throw unknown?

The url getter throws new Error('Server not started') when no static URL is set and the server hasn't started. Fixed in 3973da7: the catch now explicitly re-throws anything that isn't that specific error, so unexpected errors are not silently swallowed.

sonarqubecloud · 2026-04-17T23:01:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…revert cosmetic url changes Agent-Logs-Url: https://github.com/KeetaNetwork/anchor/sessions/0bd3f93f-6749-464f-867d-98a392a18242 Co-authored-by: ezraripps <19670988+ezraripps@users.noreply.github.com>

Initial plan

94559aa

Copilot AI assigned Copilot and ezraripps Apr 16, 2026

Copilot started work on behalf of ezraripps April 16, 2026 21:40 View session

Copilot AI linked an issue Apr 16, 2026 that may be closed by this pull request

There should be a way to have multiple KeetaNetAnchorHTTPServer's routes combined #266

Open

Add KeetaNetCombinedAnchorHTTPServer for combining routes from multip…

c194795

…le servers Agent-Logs-Url: https://github.com/KeetaNetwork/anchor/sessions/adb8fb18-e173-4efe-b121-250f7a36612b Co-authored-by: ezraripps <19670988+ezraripps@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add functionality to combine routes in KeetaNetAnchorHTTPServer~~ Add KeetaNetCombinedAnchorHTTPServer to merge routes from multiple servers Apr 16, 2026

Copilot AI requested a review from ezraripps April 16, 2026 22:00

Copilot finished work on behalf of ezraripps April 16, 2026 22:00

ezraripps requested changes Apr 17, 2026

View reviewed changes

Copilot started work on behalf of ezraripps April 17, 2026 22:07 View session

Address review feedback: remove callBuildRoutes, use config in initRo…

ac464cb

…utes, validate child URLs Agent-Logs-Url: https://github.com/KeetaNetwork/anchor/sessions/f2463b59-588b-4959-99c0-b9e5ac7293c2 Co-authored-by: ezraripps <19670988+ezraripps@users.noreply.github.com>

Copilot finished work on behalf of ezraripps April 17, 2026 22:14

Copilot AI requested a review from ezraripps April 17, 2026 22:14

ezraripps requested changes Apr 17, 2026

View reviewed changes

Copilot started work on behalf of ezraripps April 17, 2026 22:59 View session

Remove #children field, add protected config getter, fix bare catch, …

3973da7

…revert cosmetic url changes Agent-Logs-Url: https://github.com/KeetaNetwork/anchor/sessions/0bd3f93f-6749-464f-867d-98a392a18242 Co-authored-by: ezraripps <19670988+ezraripps@users.noreply.github.com>

Copilot finished work on behalf of ezraripps April 17, 2026 23:06

Copilot AI requested a review from ezraripps April 17, 2026 23:06

Conversation

Copilot AI commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Apr 17, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 16, 2026 •

edited

Loading