PM-947: Add domain validation to pam request-access and validate-domain DTO#1877
Merged
tbjones-ks merged 1 commit intoPM-947-privileged-cloud-managementfrom Mar 18, 2026
Conversation
Change List: - Added GatewayActionIdpValidateDomain DTO for rm-validate-domain action - Updated pam request-access to validate user domain against IdP before sending approval notification - Uncommented notification API call in pam request-access
tbjones-ks
merged commit a765f17
into
PM-947-privileged-cloud-management
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add domain validation to
pam request-accesscommand. Before sending an approval notification to the record owner, Commander dispatchesrm-validate-domainto the gateway to verify the requesting user's email domain is managed by the IdP. Fails fast if the domain is invalid.Issue
Changes
GatewayActionIdpValidateDomainDTO forrm-validate-domainaction inpam_dto.pypam_request_access.py:rm-validate-domainto gateway before sending notificationvault/notifications_sendAPI callBreaking Changes
None
Testing Performed