Skip to content

Improve Display Impl - Each ValidationError should be on its own line #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarashy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Display Impl - Each ValidationError should be on its own line #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions validator/src/display_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ use crate::{ValidationError, ValidationErrors, ValidationErrorsKind};
impl fmt::Display for ValidationError {
fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
if let Some(msg) = self.message.as_ref() {
write!(fmt, "{}", msg)
writeln!(fmt, "{}", msg)
} else {
write!(fmt, "Validation error: {} [{:?}]", self.code, self.params)
writeln!(fmt, "Validation error: {} [{:?}]", self.code, self.params)
}
}
}
Expand Down
10 changes: 7 additions & 3 deletions validator/tests/display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,13 @@ mod tests {

#[test]
fn test_nested_vec() {
let bad_foo = Foo { foo: "hi!".into() };
let bad_baz = Baz { baz: vec![bad_foo] };
let bad_foo_1 = Foo { foo: "hi!".into() };
let bad_foo_2 = Foo { foo: "hi!".into() };
let bad_baz = Baz { baz: vec![bad_foo_1, bad_foo_2] };
let err = format!("{}", bad_baz.validate().unwrap_err());
assert_eq!(err, "baz[0].foo: Please provide a valid foo!");
assert_eq!(
err,
"baz[0].foo: Please provide a valid foo!\nbaz[1].foo: Please provide a valid foo!"
);
}
}