Skip to content

Conversation

@ZakDggn
Copy link
Contributor

@ZakDggn ZakDggn commented Mar 18, 2025

The documentation for ToString states that

ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free.

The ToString implementation also used the old default version (2y). HashParts::format() can be called instead which uses the new default version (2b). This required changing HashParts::format() to take a reference to self instead of consuming it.

@Keats
Copy link
Owner

Keats commented Mar 23, 2025

Looks like a legit test failure?

@ZakDggn
Copy link
Contributor Author

ZakDggn commented Mar 24, 2025

Oops! I hadn't noticed that one of the tests was using to_string(). I've updated it to use 2b instead of 2y and all the tests are passing now.

@Keats Keats merged commit bbc28fa into Keats:master Aug 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants