feat: auto-select screen based on cursor position for recording#67
Open
AnKh99 wants to merge 1 commit into
Open
feat: auto-select screen based on cursor position for recording#67AnKh99 wants to merge 1 commit into
AnKh99 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the knox projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements automatic screen selection based on the mouse cursor location for both full-screen and area (region) recording.
Why is this needed?
Previously,
ScreenRecordingManagerdefaulted to recording the first display inSCShareableContent.displays(content.displays.first), which:NSScreen.screens.first).Key Changes
RegionSelectionOverlay.swift:RegionSelectionstruct to capture and pass the target display'sCGDirectDisplayIDusing the selected screen's device description.ScreenRecordingManager.swift:NSEvent.mouseLocation) to automatically record the active screen.displayIDto filter the correct display and dynamically mapped the area coordinates relative to that screen's frame in the Quartz coordinate system.How to test