Open
Conversation
tuanna-hsp
reviewed
Apr 20, 2018
| dependencies { | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) | ||
| testCompile 'junit:junit:4.12' | ||
| compile 'org.jetbrains:annotations-java5:15.0' |
Contributor
There was a problem hiding this comment.
Using this type of annotation is generally good for the IDE to spot bugs and output some warnings.
But in this case I think it not so important to add a lib just for a single @nullable. Which IMHO, can be omitted without any problems.
tuanna-hsp
reviewed
Apr 20, 2018
| public void setOnKeyListener(OnKeyListener onKeyListener) { | ||
| super.setOnKeyListener(onKeyListener); | ||
| mOnKeyListener = onKeyListener; | ||
| } |
Contributor
There was a problem hiding this comment.
I think it not necessary to override this method, then save the reference which I don't see being call anywhere.
tuanna-hsp
reviewed
Apr 20, 2018
| * @return Current HUD | ||
| */ | ||
| public KProgressHUD setOnKeyListener(@Nullable DialogInterface.OnKeyListener onKeyListener) { | ||
| this.mProgressDialog.setOnKeyListener(onKeyListener); |
Contributor
There was a problem hiding this comment.
Just this is nice. You don't need to make any changes inside dialog class (I commented below).
Contributor
|
Sorry for late reply. Your PR and the docs-reformatting is welcome. |
Author
|
But I am using your library and in certain activity I need to set key
*setOnKeyListener.*
…On Fri, Apr 20, 2018 at 9:05 PM Nguyễn Anh Tuấn ***@***.***> wrote:
Sorry for the late reply. Thank for the PR and the docs-reformatting.
I have left some comments, take a look when you have time and update the
PR if neccesary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARPSunVfMkV_TsYMkbBXNmksJdWLwPioks5tqgAlgaJpZM4RWXR7>
.
--
Thanks & Regards,
*Mr. Upendra Shah.*
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added keylistner for doing custom on back press key and other keys too