Skip to content

fix(pds-text): add span as tag option#686

Draft
QuintonJason wants to merge 1 commit intomainfrom
fix/pds-text-span-tag
Draft

fix(pds-text): add span as tag option#686
QuintonJason wants to merge 1 commit intomainfrom
fix/pds-text-span-tag

Conversation

@QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented Feb 27, 2026

Description

Adds span as a valid option for the tag prop on pds-text, so the component can render as a <span> for inline text (e.g. inside buttons, labels, or other inline contexts) while keeping existing pds-text styling and behavior.

No new dependencies. No documentation update beyond the auto-generated readme.md from the new prop value.

Fixes DSS-182

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@QuintonJason QuintonJason self-assigned this Feb 27, 2026
@netlify
Copy link

netlify bot commented Feb 27, 2026

Deploy Preview for pine-design-system failed.

Name Link
🔨 Latest commit 5219d22
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/69a1ab13d6adbf0008b967d8

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant