Preparing PR: Metallizing GraphBwd#1
Open
KIwabuchi wants to merge 12 commits into
Open
Conversation
neffrw
reviewed
Jun 6, 2023
KIwabuchi
commented
Jun 6, 2023
| #if defined ENABLE_MEMKIND | ||
| RRRsetAllocator<vertex_type> allocator(libmemkind::kinds::DAX_KMEM_PREFERRED); | ||
| #elif defined ENABLE_METALL | ||
| RRRsetAllocator<vertex_type> allocator("/mnt/bb/reeceneff/memkind_tmp", 0); |
Owner
Author
There was a problem hiding this comment.
Should we use the old version?
Collaborator
There was a problem hiding this comment.
@neffrw Same path as metall RRR set destination
| #if defined ENABLE_MEMKIND | ||
| RRRsetAllocator<vertex_type> allocator(libmemkind::kinds::DAX_KMEM_PREFERRED); | ||
| #elif defined ENABLE_METALL | ||
| RRRsetAllocator<vertex_type> allocator("/mnt/bb/reeceneff/memkind_tmp", 0); |
Owner
Author
There was a problem hiding this comment.
Should we use the old version?
Owner
Author
There was a problem hiding this comment.
It looks like there are some conflicts with the latest master version. How do we want to merge?
Owner
Author
There was a problem hiding this comment.
It looks like there is a conflict with the latest master version. How do we want to merge?
|
|
||
| metall::manager &metall_manager_instance() { | ||
| static metall::manager manager(metall::create_only, "/tmp/ripples"); | ||
| static metall::manager manager(metall::create_only, "/dev/shm/metall_tmp"); |
Owner
Author
There was a problem hiding this comment.
Need a way to configure this pass at run time?
Collaborator
There was a problem hiding this comment.
@neffrw implement for both memkind and metall RRR Sets
neffrw
requested changes
Jun 6, 2023
|
|
||
| metall::manager &metall_manager_instance() { | ||
| static metall::manager manager(metall::create_only, "/tmp/ripples"); | ||
| static metall::manager manager(metall::create_only, "/dev/shm/metall_tmp"); |
Collaborator
There was a problem hiding this comment.
@neffrw implement for both memkind and metall RRR Sets
| #if defined ENABLE_MEMKIND | ||
| RRRsetAllocator<vertex_type> allocator(libmemkind::kinds::DAX_KMEM_PREFERRED); | ||
| #elif defined ENABLE_METALL | ||
| RRRsetAllocator<vertex_type> allocator("/mnt/bb/reeceneff/memkind_tmp", 0); |
Collaborator
There was a problem hiding this comment.
@neffrw Same path as metall RRR set destination
| #if defined ENABLE_MEMKIND | ||
| RRRsetAllocator<vertex_type> allocator(libmemkind::kinds::DAX_KMEM_PREFERRED); | ||
| #elif defined ENABLE_METALL | ||
| RRRsetAllocator<vertex_type> allocator("/mnt/bb/reeceneff/memkind_tmp", 0); |
Merged
Feature/metall
neffrw
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this PR to review and discuss the new version before creating a PR to the original repository.