Fix/honor per engine timeout#182
Merged
Merged
Conversation
Slow coding-plan engines (e.g. zai-coding-plan-glm-5.1) declare their own
EngineDefinition.timeout (180s), but dispatch only used the generic command
default (brainstorm/tribunal/council = 120s), so a slow engine got cut off
mid-answer and lost its slot ("Failed to respond: Request timed out").
Raise options.timeout to the engine's declared timeout when it's higher,
at the single dispatch chokepoint — so all exec orchestration honors it.
Precedent: forge stages.kern:106 already reads engine.timeout.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…utation
Addresses agon review of the prior commit (4/4 reviewers):
- Coverage: the timeout override was only in dispatch(); dispatchStream,
dispatchAgent, dispatchAgentStream still cut slow engines at the command
default. Extract a withEngineTimeout() helper and call it from all four.
- No mutation: helper returns a NEW options object ({...options, timeout})
instead of mutating the caller's DispatchOptions (safe under reuse/retry).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.