feat(intent): deterministic chat review dispatch on "review with <eng…#176
Merged
Merged
Conversation
…ines>" You shouldn't have to think about a target. "review with codex claude agy" (and politeness variants like "can you review with codex claude and agy") now dispatch a real review directly from chat — target defaults to uncommitted — instead of being handed to the Cesar model, which a weak engine could fake or mis-target to the current branch. - Wires the previously-dead parseSemanticReviewShortcut into detectIntent. It's high-precision: requires a review verb + "with <known engine(s)>" (validated against the engine regex, so "review with me the options" stays auto), tolerates politeness prefixes, and excludes compound "fix then review" so Cesar still owns the full sequence. Forge/tribunal/campfire remain slash-only. - Fixes parseExplicitEngineIds so space-separated engines are captured: "with codex claude agy" now yields all three, not just codex. (`/review codex claude agy` already worked — engines positional, target optional/uncommitted; added a 3-engine test to lock it in.) Updates the older "review is slash-only from chat" tests to the new contract; full suite green: 1999/1999. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ines>"
You shouldn't have to think about a target. "review with codex claude agy" (and politeness variants like "can you review with codex claude and agy") now dispatch a real review directly from chat — target defaults to uncommitted — instead of being handed to the Cesar model, which a weak engine could fake or mis-target to the current branch.
(
/review codex claude agyalready worked — engines positional, target optional/uncommitted; added a 3-engine test to lock it in.)Updates the older "review is slash-only from chat" tests to the new contract; full suite green: 1999/1999.