tools/extractor.py: only access .path_id and .type.name on object reader#295
Merged
K0lb3 merged 1 commit intoK0lb3:masterfrom Feb 3, 2025
Merged
tools/extractor.py: only access .path_id and .type.name on object reader#295K0lb3 merged 1 commit intoK0lb3:masterfrom
K0lb3 merged 1 commit intoK0lb3:masterfrom
Conversation
Currently there is an `obj = obj.read()` overwrite that changes the object reader to a direct object, but some other lines still expect the original object reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is an
obj = obj.read()overwrite that changes the object reader to a direct object, but some other lines still expect the original object reader