rh: add REST endpoint that triggers DHCR form submission [sc-14556]

[aidencullo]

Shortcut: sc-14556

Summary

• Adds POST /rh/submit — validates RhForm, creates a RentalHistoryRequest, returns the row id.
• Wires path("rh/", include("rh.urls")) into project/urls.py.
• Persists fields that ModelForm.save() was silently dropping (phone, address, borough, zipcode, address_verified) because RhForm.Meta.fields only declares three.
• Adds an opt-in Playwright submitter (rh/dhcr_portal_submit.py) for the eventual DHCR portal channel referenced in sc-14556. Dry-run by default (DHCR_PORTAL_DRY_RUN=1); no live submission happens without HCR sign-off.
• Extracts the HCR reference number (#YYMMDD-NNNNNN) from the post-submit success page and returns it on SubmissionResult.reference_number for the caller to persist.
• Adds a manage.py test_dhcr_portal_empty smoke command that opens portal.hcr.ny.gov/app/ask, clicks Submit on an empty form, and prints the server-side validation banner — confirms reachability without creating a record.

How it works at a high level

1. External caller POSTs tenant info as JSON to /rh/submit → Django saves a RentalHistoryRequest row, returns its id.
2. (Separate, gated, not yet wired into the view) The Playwright bot launches headless Chromium, fills HCR's form at portal.hcr.ny.gov/app/ask, clicks Submit, scrapes the reference number off the success page.

The end-to-end Playwright pipeline (fill → submit → success-banner wait → body scrape → regex match r"#(\\d{6}-\\d{6})") has been validated against a real HCR submission and successfully extracted a live reference.

Test plan

• curl -X POST :8000/rh/submit with no body → 400 with {"errors": {...}}.
• curl -X POST :8000/rh/submit -H 'Content-Type: application/json' -d '{...full form...}' → 201 with {"id": <pk>}, row appears in rh_rentalhistoryrequest with all fields persisted.
• (manual) pipenv run python manage.py test_dhcr_portal_empty after installing playwright + chromium → reports validation banner, no record created at HCR.

Not in this PR

• Bearer-token auth on /rh/submit — the sibling REST endpoints (/gce/upload, /efnyc/upload, /mailchimp/subscribe) gate access with authorize_with_token(...) + a CORS allowlist. /rh/submit should follow that pattern before going public.
• playwright is not added to Pipfile; the management command + portal submitter require an ad-hoc install. Production use needs Chromium baked into the Dockerfile.
• No dhcr_reference_number / portal_submitted_at columns on RentalHistoryRequest yet — needed before wiring submit_via_portal into the /rh/submit view so the reference can be persisted.
• No HCR authorization to switch the production channel from email to portal submission. DHCR_PORTAL_DRY_RUN=0 must not be flipped until that's in writing.

🤖 Generated with Claude Code

[aidencullo]

stale

[aidencullo]

Update since the original summary:

The PR now wires submit_via_portal() into POST /rh/submit. The endpoint creates a RentalHistoryRequest, calls the portal submitter, returns portal status info, and persists portal_result.reference_number to a new dhcr_reference_number column when present.

Also added:

• RentalHistoryRequest.dhcr_reference_number + migration
• admin list display for dhcr_reference_number
• local/debug GET /rh/requests endpoint, guarded by DEBUG
• tests for reference-number persistence and local request listing

Still not included:

• bearer-token auth / CORS allowlist for public use
• Playwright/Chromium baked into project dependencies or production image on this branch
• HCR sign-off to disable dry-run in production

Important local behavior:
POST /rh/submit can return 201 even when the portal step fails, because the DB row was created. Check the portal object in the JSON response for success, dry_run, reference_number, and error.