remove contentful-common-strings and the old covid banner using it#401
Open
austensen wants to merge 2 commits into
Open
remove contentful-common-strings and the old covid banner using it#401austensen wants to merge 2 commits into
austensen wants to merge 2 commits into
Conversation
Member
Author
|
somehow after just re-running the deploy a bunch more times it worked without any changes, so this isn't really needed right now anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to investigate a failing build related to missing contentful data for the learning center, but in trying to get the local development set up I ran into some issues with our custom package
contentful-common-strings. I'd had problems with this recently in another project, and it's only being used here for an old covid banner that we don't need, so I've just removed the banner and package.