Fix type safety and error handling in Azure Login action#21
Draft
Copilot wants to merge 2 commits intocopilot/fix-login-issuefrom
Draft
Fix type safety and error handling in Azure Login action#21Copilot wants to merge 2 commits intocopilot/fix-login-issuefrom
Copilot wants to merge 2 commits intocopilot/fix-login-issuefrom
Conversation
- Fix unsafe error handling by checking error type before accessing properties - Replace loose equality (==) with strict equality (===) for type safety - Remove all 'any' types and use proper TypeScript ExecOptions interface - Improve error messages to show only error message, not full object toString - Add proper type checking before accessing error.stack to prevent runtime errors These changes enhance the reliability and maintainability of the codebase while maintaining backward compatibility. Co-authored-by: Jury1981 <210622247+Jury1981@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update login functionality for better user experience
Fix type safety and error handling in Azure Login action
Feb 4, 2026
|
This PR is idle because it has been open for 14 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The codebase had unsafe error handling that could crash at runtime and weak TypeScript typing that defeated compile-time safety.
Changes
Error handling
error.stackanderror.messagepropertiesType safety
anytypes withExecOptionsinterface from@actions/execAzureCliLogin.executeAzCliCommand(),AzPSUtils.runPSScript()Code quality
==) with strict equality (===)preCleanupenvironment variable check in main.tsOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.