refactoring by t-kojima#6
Open
t-kojima wants to merge 1 commit into
Open
Conversation
rename file (transport.rb -> transpose.rb) use Array#transpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ファイル・メソッド名の変更
transport(輸送)より**transpose(転置)**が適切かと思います。
Array#transposeの利用
メインのロジックはArray#transposeで同じ動作ができます。
transported_array = array.transposeString#each_line,&:methodの利用
一行目は以下のように置き換えられます。
前
array = source.split("\n").map {|s| s.split(' ')}後
array = source.each_line.map(&:split)しかし、そのままのほうが一行目と三行目が全く逆の処理をしていることが分かりやすいので修正していません。
一行目
array = source.split("\n").map {|s| s.split(' ')}三行目
transposed_array.map {|s| s.join(' ')}.join("\n")