Skip to content

refactoring by t-kojima#6

Open
t-kojima wants to merge 1 commit into
JunichiIto:masterfrom
t-kojima:refactoring-t2kojima
Open

refactoring by t-kojima#6
t-kojima wants to merge 1 commit into
JunichiIto:masterfrom
t-kojima:refactoring-t2kojima

Conversation

@t-kojima

Copy link
Copy Markdown

ファイル・メソッド名の変更

transport(輸送)より**transpose(転置)**が適切かと思います。

Array#transposeの利用

メインのロジックはArray#transposeで同じ動作ができます。

rows_count = array.first.count

transported_array = []
0.upto(rows_count - 1) do |i|
  transported_array << array.map {|a| a[i]}
end

transported_array = array.transpose

String#each_line,&:methodの利用

一行目は以下のように置き換えられます。

array = source.split("\n").map {|s| s.split(' ')}
array = source.each_line.map(&:split)

しかし、そのままのほうが一行目と三行目が全く逆の処理をしていることが分かりやすいので修正していません。

一行目array = source.split("\n").map {|s| s.split(' ')}
三行目transposed_array.map {|s| s.join(' ')}.join("\n")

rename file (transport.rb -> transpose.rb)
use Array#transpose
@t-kojima t-kojima changed the title refactoring refactoring by t-kojima Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant