Set default stopping tolerances to epsilon^1/3#330
Merged
dpo merged 3 commits intoJuliaSmoothOptimizers:masterfrom May 5, 2026
Merged
Set default stopping tolerances to epsilon^1/3#330dpo merged 3 commits intoJuliaSmoothOptimizers:masterfrom
dpo merged 3 commits intoJuliaSmoothOptimizers:masterfrom
Conversation
Collaborator
MaxenceGollier
left a comment
There was a problem hiding this comment.
Thank you @BenjaminPINEAU!
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
===========================================
+ Coverage 61.53% 83.85% +22.31%
===========================================
Files 11 12 +1
Lines 1292 1641 +349
===========================================
+ Hits 795 1376 +581
+ Misses 497 265 -232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the stopping tolerances for the solvers (see #324).$\sqrt{\epsilon_M}$ to $\epsilon^{1/3}_M$ @dpo
Transition from