Skip to content

Implementation field#416

Open
BenjaminPINEAU wants to merge 7 commits intoJuliaSmoothOptimizers:mainfrom
BenjaminPINEAU:implementation_features
Open

Implementation field#416
BenjaminPINEAU wants to merge 7 commits intoJuliaSmoothOptimizers:mainfrom
BenjaminPINEAU:implementation_features

Conversation

@BenjaminPINEAU
Copy link
Copy Markdown

@BenjaminPINEAU BenjaminPINEAU commented May 6, 2026

Add a new field implementation (see #415) that take jump if the problem is defined in PureJuMP, adnlpmodels if the problem is defined in ADNLPProblems, or both if both.

tmigot
tmigot requested changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BenjaminPINEAU for the PR. A few comments to start with.

Comment thread Project.toml Outdated
JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
JuMP = "4076af6c-e467-56ae-b986-b466b2749572"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
NLPModels = "a4795742-8479-5a88-8948-cc11e1c8c1a6"
Copy link
Copy Markdown
Member

@tmigot tmigot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the Project.toml in your PR

Comment thread .DS_Store
Copy link
Copy Markdown
Member

@tmigot tmigot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR

Comment thread src/.DS_Store
Copy link
Copy Markdown
Member

@tmigot tmigot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR

@tmigot tmigot requested a review from Copilot May 8, 2026 20:00
Copilot AI reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@tmigot tmigot linked an issue May 8, 2026 that may be closed by this pull request
Distinguish PureJuMP problems and ADNLPProblems ? #415
Open
@tmigot
Copy link
Copy Markdown
Member

tmigot commented May 8, 2026

@BenjaminPINEAU We could add a test in the unit tests that checks that:

  • All the problems that have :jump are in names(PureJuMP) but not in names(ADNLPProblems)
  • The same for :adnlpmodels
  • For both, we check that they are in both.
    What do you think?

@BenjaminPINEAU
Copy link
Copy Markdown
Author

BenjaminPINEAU commented May 10, 2026

@tmigot I apologize for the DS_Store files, they aren't displaying in my code editor and I missed them in the PR.
The new test looks good; I will be working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@tmigot tmigot tmigot requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Distinguish PureJuMP problems and ADNLPProblems ?

3 participants

@BenjaminPINEAU @tmigot