Documentation for adding new problems in contributing.md#410
Merged
tmigot merged 17 commits intoJuliaSmoothOptimizers:mainfrom May 10, 2026
Merged
Documentation for adding new problems in contributing.md#410tmigot merged 17 commits intoJuliaSmoothOptimizers:mainfrom
tmigot merged 17 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
…, including constraints, compatibility, meta fields, allocation, and scalability
…d, as suggested by validation analysis PDF
…n requirements for benchmarking, as suggested by validation analysis PDF
Clarified requirements for meta field completeness and validation.
arnavk23
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
===========================================
- Coverage 99.80% 54.34% -45.47%
===========================================
Files 1084 1138 +54
Lines 12319 13371 +1052
===========================================
- Hits 12295 7266 -5029
- Misses 24 6105 +6081 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmigot
requested changes
Mar 29, 2026
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Corrected punctuation and formatting in the contributing guidelines.
tmigot
reviewed
Mar 31, 2026
Member
tmigot
left a comment
tmigot
left a comment
There was a problem hiding this comment.
Some comments. Don't hesitate to go into details.
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the contributor documentation with guidance for validating and reviewing newly added optimization problems, aiming to standardize expectations across ADNLPProblems and PureJuMP implementations.
Changes:
- Added a “Validating new problems” section with validation guidance (meta accuracy, consistency checks, scalable problems, least-squares handling).
- Added a structured reviewer checklist covering meta, definition, implementation, sanity checks, and zero-allocation expectations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added guidelines for handling Nonlinear Least Squares (NLS) problems in contributing documentation.
Co-authored-by: Tangi Migot <tangi.migot@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tmigot
requested changes
Apr 6, 2026
tmigot
reviewed
Apr 6, 2026
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Member
|
@arnavk23 I see that some comments still needs to be Resolved ? |
Contributor
Author
I have tried to resolve them but kept them active as I am a bit unsure. |
Contributor
Author
|
@tmigot Let's work further on this and get this merged as quickly as we can. |
tmigot
requested changes
May 10, 2026
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
tmigot
requested changes
May 10, 2026
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dpo @tmigot