Update breakage: use organization-wide workflow#170
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s breakage checking setup to rely on organization-wide reusable GitHub Actions workflows (per JuliaSmoothOptimizers/.github#18).
Changes:
- Replace the in-repo Breakage workflow implementation with a reusable workflow call.
- Add a workflow-run triggered job to post/update breakage results via the org-wide comment workflow.
- Remove now-unused local
.breakagetooling (script + Project.toml).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/CommentBreakage.yml |
Adds a workflow that triggers on Breakage completion and delegates PR commenting to the org reusable workflow. |
.github/workflows/Breakage.yml |
Replaces the old matrix/build/test/comment logic with an org reusable workflow invocation. |
.breakage/get_jso_users.jl |
Removes obsolete script previously used to compute dependent packages. |
.breakage/Project.toml |
Removes obsolete dependencies for the deleted .breakage script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @MaxenceGollier ! Thanks for this, I think copilot's comments are valid for this PR and the others as well. Thanks |
|
Ha, i didn't catch this. Thanks for the comment! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }) | ||
| } | ||
| breakage: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main No newline at end of file |
There was a problem hiding this comment.
The reusable workflow reference is pinned to the moving main branch. For supply-chain safety and reproducibility, consider pinning this to an immutable ref (a tag or commit SHA) and updating intentionally when needed.
| uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@main | |
| uses: JuliaSmoothOptimizers/.github/.github/workflows/Breakage.yml@0123456789abcdef0123456789abcdef01234567 |
|
|
||
| jobs: | ||
| comment_pr: | ||
| uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main No newline at end of file |
There was a problem hiding this comment.
This reusable workflow call is pinned to the moving main branch. Consider pinning to a tag or commit SHA to avoid unexpected behavior changes and reduce supply-chain risk.
| uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@main | |
| uses: JuliaSmoothOptimizers/.github/.github/workflows/CommentBreakage.yml@<FULL_40_CHAR_COMMIT_SHA> |
|
@MaxenceGollier I updated the PR to fix the end of file character, as otherwise the Linter was failing. |
Following JuliaSmoothOptimizers/.github#18.