Skip to content

add compat setting for Documenter and remove strict keyword of makedocs#59

Merged
oscardssmith merged 1 commit intomainfrom
hr/fix_docs
May 21, 2025
Merged

add compat setting for Documenter and remove strict keyword of makedocs#59
oscardssmith merged 1 commit intomainfrom
hr/fix_docs

Conversation

@ranocha
Copy link
Member

@ranocha ranocha commented May 21, 2025

Documenter.jl failed in #58 since the strict keyword argument has been removed from makedocs. I added a compat setting for Documenter.jl and removed this keyword.

@efaulhaber: Maybe you could review this as well?

@ranocha ranocha requested a review from oscardssmith May 21, 2025 15:24
@ranocha ranocha added bug Something isn't working documentation Improvements or additions to documentation labels May 21, 2025
Copy link
Contributor

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oscardssmith oscardssmith merged commit 54bdc4e into main May 21, 2025
34 checks passed
@oscardssmith oscardssmith deleted the hr/fix_docs branch May 21, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants