Skip to content

New version: JuliaFormatter v2.6.1#157185

Open
JuliaRegistrator wants to merge 1 commit into
masterfrom
registrator-juliaformatter-98e50ef6-v2.6.1-3ec72572ee
Open

New version: JuliaFormatter v2.6.1#157185
JuliaRegistrator wants to merge 1 commit into
masterfrom
registrator-juliaformatter-98e50ef6-v2.6.1-3ec72572ee

Conversation

@JuliaRegistrator
Copy link
Copy Markdown
Contributor

Fixed a bug where matrices with `;;\n` horizontal concatenation separators were being formatted into invalid code. (#1029)

UUID: 98e50ef6-434e-11e9-1051-2b60c6c9e899
Repo: https://github.com/JuliaEditorSupport/JuliaFormatter.jl.git
Tree: c21c32757e2af13bb2d273ff736e67b948e6976b

Registrator tree SHA: 50f504d641745716a5b3eabaf681d3a4937d2ae3
JuliaRegistrator referenced this pull request in JuliaEditorSupport/JuliaFormatter.jl Jun 5, 2026
## Summary

Fix formatting for wrapped horizontal concatenation rows followed by
repeated semicolon n-dimensional concatenation separators.

JuliaSyntax can parse a formatted result such as `[a b;;\n c d]` as an
`Hcat` node with semicolon leaves rather than as the original `Ncat`
shape. The formatter previously joined that syntactic newline and
inserted whitespace between semicolon tokens, producing invalid Julia
like `a b ; ; c d`.

This PR preserves the required newline after wrapped ncat separators,
avoids manufacturing whitespace before semicolon separators, and adds
explicit Hcat nesting hooks so YAS/SciML keep their second-pass
alignment.

---------

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
@penelopeysm
Copy link
Copy Markdown
Contributor

penelopeysm commented Jun 5, 2026

Actually I'm pretty sure this has a bug so block for now

JuliaEditorSupport/JuliaFormatter.jl#1037 wasn't introduced in this release, but I want to fix it before releasing this.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants