Skip to content

Fix dangling suffix pointer in tracked library info #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ViralBShah wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix dangling suffix pointer in tracked library info #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ void clear_loaded_libraries() {
for (int idx=0; idx<MAX_TRACKED_LIBS; ++idx) {
if (lbt_config.loaded_libs[idx] != NULL) {
free(lbt_config.loaded_libs[idx]->libname);
free((void *)lbt_config.loaded_libs[idx]->suffix);
free(lbt_config.loaded_libs[idx]->active_forwards);
//close_library(lbt_config.loaded_libs[idx]->handle);
free(lbt_config.loaded_libs[idx]);
Expand Down Expand Up @@ -110,7 +111,12 @@ void record_library_load(const char * libname, void * handle, const char * suffi
new_libinfo->libname = (char *) malloc(namelen);
memcpy(new_libinfo->libname, libname, namelen);
new_libinfo->handle = handle;
new_libinfo->suffix = suffix;
// Deep-copy the suffix: it may point to a caller-supplied `suffix_hint` (e.g. a stack
// buffer in `init()`), so we cannot retain the original pointer past this call.
size_t suffixlen = strlen(suffix) + 1;
char * suffix_copy = (char *) malloc(suffixlen);
memcpy(suffix_copy, suffix, suffixlen);
new_libinfo->suffix = suffix_copy;
new_libinfo->active_forwards = (uint8_t *)malloc(sizeof(uint8_t)*(NUM_EXPORTED_FUNCS/8 + 1));
memcpy(new_libinfo->active_forwards, forwards, sizeof(uint8_t)*(NUM_EXPORTED_FUNCS/8 + 1));
new_libinfo->interface = interface;
Expand Down
Loading