Add tests with reference BLAS and LAPACK#128
Conversation
|
|
||
| # Test against MKL_jll using `libmkl_rt`, which is :LP64 by default | ||
| if MKL_jll.is_available() | ||
| if MKL_jll.is_available() && !Sys.iswindows() |
There was a problem hiding this comment.
Why are you limiting this to non-windows?
There was a problem hiding this comment.
I got an issue with rights ln ibmkl_rt.dll but it seems to be fixed with the latest JLL (2024.2.0).
I still the issue here with buildkit :(
There was a problem hiding this comment.
I believe that was the first MKL release where all our known issues got sorted out.
| end | ||
|
|
||
| @testset "Vanilla ReferenceBLAS_jll (ILP64)" begin | ||
| run_all_tests("blas", reverse(ReferenceBLAS_jll.LIBPATH_list), :ILP64, "", tests = [dgemm, sdot]) |
There was a problem hiding this comment.
What is the error that you were seeing here? Looking through the CI logs, I don't understand.
de61b4d to
cccdca2
Compare
|
The failure on armv7l is silly; it's because we use Julia v1.7 (the last released version on armv7l) but LAPACK32_jll says it needs Julia v1.9+, presumably because it relies on some newer libblastrampoline versions. The failures on windows look real however. |
|
The odd thing is that adding ReferenceBLAS tests is failing the regular OpenBLAS tests. So presumably, there is some issues with symbols being messed up. I wonder if we can run these as tests in separate processes, and only load one set of BLAS/LAPACK in each process. Presumably we should also separate MKL to keep it all clean. |
|
The exit code on windows apparently suggests that it is a DLL not found error. |
`info` is a `blasint`, which is 32-bit in LP64 builds, so `%ld` triggers a -Wformat warning (and is incorrect) there. Use `%d` for LP64 and `%ld` for ILP64. Pulled from #128. Co-authored-by: Alexis Montoison <alexis.montoison@polymtl.ca> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
#173 is an alternative implementation that does test ReferenceBLAS. |
Pulled from JuliaLinearAlgebra#128. Co-authored-by: Alexis Montoison <alexis.montoison@polymtl.ca> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
I have the following tests that are not working:
I commented them.
I suspect that it's because they are already installed.
We should maybe modify the name and soname of the ILP64 libraries of
ReferenceBLAS_jll.jlandLAPACK_jll.jl:libblas.so and liblapack.so -> libblas64.so and liblapack64.so.