Set docs preview#100
Merged
Merged
Conversation
Contributor
Author
|
the error on some travis builds seems unrelated |
Contributor
Author
|
@lbenet could you try to re-trigger the Travis build? |
Member
|
I've restarted the travis build (on those jobs that didn't pass only). |
Member
|
All tests are passing (except some in nightly, which I think is related to printing, so irrelevant). Shall I go ahead and merge? |
Member
|
Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address comment #98 (review), once this is merged I'll rebase my docs PRs.. But there is a Note in blue ("Pull requests made from forks will not have previews. ...") so it may not work in #98 and #99 because they are from a fork.