Skip to content

Remove explicit != methods for Dual #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 2 commits into from
Jan 28, 2026
Merged

Remove explicit != methods for Dual #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f74d88
Remove explicit `!=` methods for Dual
JamesWrigley Jan 28, 2026
b50f9a7
Bump version
JamesWrigley Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ForwardDiff"
uuid = "f6369f11-7733-5829-9624-2563aa707210"
version = "1.3.1"
version = "1.3.2"

[deps]
CommonSubexpressions = "bbf7d656-a473-5ed7-a52c-81e309532950"
Expand Down
9 changes: 1 addition & 8 deletions src/dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ for pred in UNARY_PREDICATES
end

# Before PR#481 this loop ran over this list:
# BINARY_PREDICATES = Symbol[:isequal, :isless, :<, :>, :(==), :(!=), :(<=), :(>=)]
# BINARY_PREDICATES = Symbol[:isequal, :isless, :<, :>, :(==), :(<=), :(>=)]
# Not a minimal set, as Base defines some in terms of others.
@define_binary_dual_op(
Base.:(<),
Expand Down Expand Up @@ -426,13 +426,6 @@ for pred in [:isequal, :(==)]
end
end

@define_binary_dual_op(
Base.:(!=),
(!=)(value(x), value(y)) || (!=)(partials(x), partials(y)),
(!=)(value(x), y) || !iszero(partials(x)),
(!=)(x, value(y)) || !iszero(partials(y)),
)

########################
# Promotion/Conversion #
########################
Expand Down