docs: note GetBible colon URL-encoding gotcha#7
Open
bcordis wants to merge 1 commit into
Open
Conversation
GetBible's v2 endpoint rejects %3A in references like 'Luke 7:36-38'; the colon must stay literal. Document the rawurlencode + str_replace pattern already used in GetBibleProvider so future changes preserve it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents a GetBible-specific URL-encoding gotcha in
CLAUDE.md. The GetBible v2 endpoint (https://query.getbible.net/v2/{translation}/{reference}) rejects%3Afor the chapter:verse colon — the colon must be sent literally.The doc records the pattern already implemented in
GetBibleProvider::getPassage():This is doc-only; no code changes. Verified against
src/Bible/Provider/GetBibleProvider.php:68.Why
urlencode()breaks spaces (+) andrawurlencode()alone encodes the colon to%3A— either would silently break GetBible requests. Documenting it prevents a regression during future refactors.🤖 Generated with Claude Code