feat: add CLIENT SETNAME for connection identification#1
Open
atao2004 wants to merge 1 commit into
Open
Conversation
Adds client_name="sglang_cache_client" to the valkey.Valkey() constructor so the connection is identifiable via CLIENT LIST on the server. Fixes sgl-project#26418 Signed-off-by: Anna Tao <annatao2004@gmail.com>
This was referenced May 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
client_name="sglang_cache_client"to thevalkey.Valkey()constructor inhicache_valkey_storage.pyso the connection is identifiable viaCLIENT LISTon the server.Related upstream PR: sgl-project#16823
Changes
One-line addition — adds
client_nameparameter to the existing Valkey client constructor.Motivation
Connections without a name appear anonymous in
CLIENT LIST. Settingclient_namesends aCLIENT SETNAMEcommand on connection, making it identifiable in monitoring dashboards and CloudWatch metrics.Risk
Zero-risk —
client_nameis a metadata-only option in valkey-py. No behavioral changes.