Expand use and function of zen-grid-item-width()#21
Open
jstoller wants to merge 4 commits into
Open
Conversation
…d-item-width() function. We will need this for more advanced features, like variable width columns. Make the function default to the total grid width if no variables are input.
Owner
|
Addressing your points:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch makes the following changes:
In addition to making the zen-grid-item-width() function more useful in its own right, which may have uses outside of the zen-grid mixins themselves, these updates open the door to more seamless future enhancements. For instance, you can now implement a non-equal grid columns by expanding zen-grid-item-width(), without negatively impacting anyone already using this plugin.