Cdspt 15587 align functionality of totals methods for all extractor subclasses#18
Merged
TiffanyCheng27 merged 8 commits intoJun 24, 2026
Conversation
… get_row_count are the same across Extracto classes
…not in dataset.measures raises an error rather than silently giving you the row count.
…t a request for a query with measure None we just return Count(*). Substituting measures happens in the Extractor layer now.
Contributor
|
Member
Author
|
I've added the missing unit tests and refactored so they all call get_total() internal metho |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This change ensures that each Extractor subclass contains:
get_row_count()
get_total(measure:str)
Calling code should now call either:
The behaviour is consistent across implementations:
Notes:
🧪 What Changed?
✅ Checklist
Code Quality
Testing
Documentation
Security & Deployment
Note that there is a change in behaviour for where a non-existent measure is specified for a total.
⚙️ Actions Required After Pulling
🧠 Context or Screenshots
🚨 Risk & Impact