CDSPT-15588 Implemented module for producing type-strict dataframes#17
Merged
TiffanyCheng27 merged 2 commits intoJun 22, 2026
Merged
Conversation
| return True | ||
| if x_str in {"false", "0"}: | ||
| return False | ||
| return pd.NA |
Contributor
There was a problem hiding this comment.
If the bool data x=1.0 or 0.0 then this convert function will return pd.NA
There might be a risk that csv save bool as float type and cause this error.
Can also consider to add trim value function for x_str
Member
Author
There was a problem hiding this comment.
I've pushed some changes to make boolean handling more robust.
…cluding native bools, floats, and string floats. Added test cases to confirm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Implemented module for producing type-strict dataframes from CSV and Hyper
🧪 What Changed?
✅ Checklist
Code Quality
Testing
Documentation
Security & Deployment
⚙️ Actions Required After Pulling
🧠 Context or Screenshots
https://jiscdev.atlassian.net/browse/CDSPT-15588
🚨 Risk & Impact