Skip to content

test(api validation): check layout query validation boundaries#1918

Closed
Shreeya1207 wants to merge 4 commits into
JhaSourav07:mainfrom
Shreeya1207:test/layout-query-validation-boundary
Closed

test(api validation): check layout query validation boundaries#1918
Shreeya1207 wants to merge 4 commits into
JhaSourav07:mainfrom
Shreeya1207:test/layout-query-validation-boundary

Conversation

@Shreeya1207
Copy link
Copy Markdown
Contributor

Description

Fixes #1464

Added validation test coverage for the ?layout= query parameter using the unsupported value unsupported_layout.

This test ensures that unsupported layout values are correctly rejected by the validation layer and that the API returns a 400 Bad Request response for invalid layout formats. The added test strengthens query parameter validation and helps prevent invalid input from reaching application logic.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Checklist before requesting a review:

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 31, 2026

@Shreeya1207 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the needs-rebase This PR has merge conflicts and needs a rebase. label May 31, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Hey @Shreeya1207, this PR has merge conflicts with the main branch.

Please pull the latest changes and resolve the conflicts so we can review it!

git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once resolved, the needs-rebase label will be removed automatically on the next check. 🙌

2 similar comments
@github-actions
Copy link
Copy Markdown

⚠️ Hey @Shreeya1207, this PR has merge conflicts with the main branch.

Please pull the latest changes and resolve the conflicts so we can review it!

git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once resolved, the needs-rebase label will be removed automatically on the next check. 🙌

@github-actions
Copy link
Copy Markdown

⚠️ Hey @Shreeya1207, this PR has merge conflicts with the main branch.

Please pull the latest changes and resolve the conflicts so we can review it!

git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once resolved, the needs-rebase label will be removed automatically on the next check. 🙌

@github-actions github-actions Bot added status:blocked This PR is blocked due to a failing CI check. and removed needs-rebase This PR has merge conflicts and needs a rebase. labels May 31, 2026
@github-actions
Copy link
Copy Markdown

🚨 Hey @Shreeya1207, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(api validation): check query validation boundaries for ?layout= parameter (Variation 5)

1 participant