fix: prevent Framer Motion props from reaching DOM elements#1900
Merged
JhaSourav07 merged 1 commit intoMay 30, 2026
Merged
Conversation
Contributor
|
@anshika1179 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🎉 Congratulations @anshika1179! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes React warnings caused by Framer Motion animation props being passed directly to native DOM elements during test execution.
The test suite's
vi.mock('framer-motion')implementation was naively spreading all component props (includingwhileHover,whileTap, andwhileInView) directly onto native HTML elements in the virtual DOM. The warnings were artifacts of the test environment, as the actual production components correctly usedmotion.*abstractions.This PR updates the mocks to intercept and strip out animation props before rendering the fallback DOM elements, completely cleaning up the test logs.
Fixes #1896
Pillar
Visual Preview
(No visual changes. This PR strictly cleans up React prop warnings during test execution and local development).
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.