Skip to content

test(cache): verify TTLCache behavior for NaN TTL value (#1399)#1888

Open
swarupio wants to merge 2 commits into
JhaSourav07:mainfrom
swarupio:test/cache-nan-ttl
Open

test(cache): verify TTLCache behavior for NaN TTL value (#1399)#1888
swarupio wants to merge 2 commits into
JhaSourav07:mainfrom
swarupio:test/cache-nan-ttl

Conversation

@swarupio
Copy link
Copy Markdown
Contributor

Description

Added a specific test case in lib/cache.test.ts to verify that setting a cache value with a NaN TTL is handled robustly. The test ensures that passing NaN does not throw an error and instead automatically resolves to the default TTL duration, allowing the cache to safely store and retrieve the item. This satisfies all acceptance criteria for the issue.

Fixes #1399

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Screenshot 2026-05-31 013010

Checklist before requesting a review:

[x] I have read the CONTRIBUTING.md file.

[x] I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).

[x] I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).

[x] My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).

[x] I have updated README.md if I added a new theme or URL parameter.

[x] I have started the repo.

[x] I have made sure that i have only one commit to merge in this PR.

[x] The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).

[x] (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

@swarupio is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@JhaSourav07
Copy link
Copy Markdown
Owner

can you solve the merge conflict?

@swarupio swarupio force-pushed the test/cache-nan-ttl branch from 5681cc4 to 6b75bb6 Compare May 30, 2026 20:11
@swarupio
Copy link
Copy Markdown
Contributor Author

can you solve the merge conflict?

there are conflicts which i didn't even touched.........

@swarupio swarupio force-pushed the test/cache-nan-ttl branch from 6b75bb6 to bccd919 Compare May 30, 2026 20:17
@github-actions
Copy link
Copy Markdown

🚨 Hey @swarupio, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(cache): verify TTLCache behavior for NaN TTL value (Variation 2)

2 participants