test(cache): verify TTLCache behavior for NaN TTL value (#1399)#1888
Open
swarupio wants to merge 2 commits into
Open
test(cache): verify TTLCache behavior for NaN TTL value (#1399)#1888swarupio wants to merge 2 commits into
swarupio wants to merge 2 commits into
Conversation
Contributor
|
@swarupio is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
can you solve the merge conflict? |
5681cc4 to
6b75bb6
Compare
Contributor
Author
there are conflicts which i didn't even touched......... |
6b75bb6 to
bccd919
Compare
|
🚨 Hey @swarupio, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a specific test case in lib/cache.test.ts to verify that setting a cache value with a NaN TTL is handled robustly. The test ensures that passing NaN does not throw an error and instead automatically resolves to the default TTL duration, allowing the cache to safely store and retrieve the item. This satisfies all acceptance criteria for the issue.
Fixes #1399
Pillar
Visual Preview
Checklist before requesting a review:
[x] I have read the CONTRIBUTING.md file.
[x] I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
[x] I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
[x] My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
[x] I have updated README.md if I added a new theme or URL parameter.
[x] I have started the repo.
[x] I have made sure that i have only one commit to merge in this PR.
[x] The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
[x] (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.