Skip to content

test(cache): verify TTLCache behavior for infinite TTL value (#1400)#1884

Open
swarupio wants to merge 2 commits into
JhaSourav07:mainfrom
swarupio:test/cache-infinite-ttl
Open

test(cache): verify TTLCache behavior for infinite TTL value (#1400)#1884
swarupio wants to merge 2 commits into
JhaSourav07:mainfrom
swarupio:test/cache-infinite-ttl

Conversation

@swarupio
Copy link
Copy Markdown
Contributor

Description

Added a specific test case in lib/cache.test.ts to verify that setting a cache value with an Infinity TTL is handled robustly. The test ensures that passing Infinity does not throw an error, successfully sets the value, and restricts expiration to a realistic maximum threshold without breaking internal Date calculations, satisfying all acceptance criteria for the issue.

Fixes #1400

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Screenshot 2026-05-31 010839

Checklist before requesting a review:

[x] I have read the CONTRIBUTING.md file.

[x] I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).

[x] I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).

[x] My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).

[x] I have updated README.md if I added a new theme or URL parameter.

[x] I have started the repo.

[x] I have made sure that i have only one commit to merge in this PR.

[x] The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).

[x] (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

@swarupio is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added type:testing Adding, updating, or fixing tests status:blocked This PR is blocked due to a failing CI check. labels May 30, 2026
@github-actions
Copy link
Copy Markdown

🚨 Hey @swarupio, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@swarupio swarupio force-pushed the test/cache-infinite-ttl branch from 745fc8d to 314da65 Compare May 30, 2026 19:51
@github-actions
Copy link
Copy Markdown

⚠️ Hey @swarupio, this PR has merge conflicts with the main branch.

Please pull the latest changes and resolve the conflicts so we can review it!

git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once resolved, the needs-rebase label will be removed automatically on the next check. 🙌

@github-actions github-actions Bot added the needs-rebase This PR has merge conflicts and needs a rebase. label May 30, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Hey @swarupio, this PR has merge conflicts with the main branch.

Please pull the latest changes and resolve the conflicts so we can review it!

git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once resolved, the needs-rebase label will be removed automatically on the next check. 🙌

@github-actions github-actions Bot removed the needs-rebase This PR has merge conflicts and needs a rebase. label May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(cache): verify TTLCache behavior for infinite TTL value (Variation 2)

1 participant