test(cache): verify TTLCache behavior for infinite TTL value (#1400)#1884
test(cache): verify TTLCache behavior for infinite TTL value (#1400)#1884swarupio wants to merge 2 commits into
Conversation
|
@swarupio is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @swarupio, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
745fc8d to
314da65
Compare
|
Please pull the latest changes and resolve the conflicts so we can review it! git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-leaseOnce resolved, the |
|
Please pull the latest changes and resolve the conflicts so we can review it! git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-leaseOnce resolved, the |
Description
Added a specific test case in lib/cache.test.ts to verify that setting a cache value with an Infinity TTL is handled robustly. The test ensures that passing Infinity does not throw an error, successfully sets the value, and restricts expiration to a realistic maximum threshold without breaking internal Date calculations, satisfying all acceptance criteria for the issue.
Fixes #1400
Pillar
Visual Preview
Checklist before requesting a review:
[x] I have read the CONTRIBUTING.md file.
[x] I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
[x] I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
[x] My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
[x] I have updated README.md if I added a new theme or URL parameter.
[x] I have started the repo.
[x] I have made sure that i have only one commit to merge in this PR.
[x] The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
[x] (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.