Skip to content

test(dashboard): add responsive ComparisonStatsCard coverag#1750

Merged
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
vaibhav051422-collab:feature/comparison-stats-card-responsive-tests
May 30, 2026
Merged

test(dashboard): add responsive ComparisonStatsCard coverag#1750
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
vaibhav051422-collab:feature/comparison-stats-card-responsive-tests

Conversation

@vaibhav051422-collab
Copy link
Copy Markdown
Contributor

@vaibhav051422-collab vaibhav051422-collab commented May 30, 2026

Description

Added a focused test suite for ComparisonStatsCard that checks responsive layout structure, positive/negative growth indicators, winner badges, and the zero-value fallback, then verified it passes with Vitest.

Fixes #1540

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

Copilot AI review requested due to automatic review settings May 30, 2026 14:11
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

@vaibhav051422-collab is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the type:testing Adding, updating, or fixing tests label May 30, 2026
Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces 10 detailed tests with 3 DOM-structure-only tests. The removed tests covered Winner badge logic, progress bar segments, and equal-value edge cases. Please restore the detailed assertions rather than replacing them with shallow structure checks.

@vaibhav051422-collab
Copy link
Copy Markdown
Contributor Author

vaibhav051422-collab commented May 30, 2026

i have restored the previous tests..please review this @JhaSourav07 @Aamod007

@JhaSourav07 JhaSourav07 merged commit 5ec6322 into JhaSourav07:main May 30, 2026
7 of 8 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Congratulations @vaibhav051422-collab! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points labels May 30, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:exceptional Outstanding contribution with exceptional implementation quality, testing. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ui): verify responsive rendering and elements of ComparisonStatsCard (Variation 4)

3 participants