[REFERENCE ONLY] feat(migrate): full CI migration — all 7 systems (split into stacked PRs) by tiulpin · Pull Request #217 · JetBrains/teamcity-cli

Viktor (tiulpin) · 2026-04-09T09:53:44Z

Warning

This PR is reference-only — do not merge. It grew too large for a single review pass. The work has been split into focused PRs starting with #226.

Why this PR is no longer active

The original scope (foundation + 7 CI converters + skill + issue template) landed at ~7.3k insertions across 42 files, which is too much to review in one shot. The code is sound and has been through multiple rounds of Codex review and bug fixes, but it needs to land in digestible slices.

Split plan

Each follow-up PR is an independent, self-contained slice against `main`. They'll land sequentially (not stacked) so each can be reviewed against the previous merged state.

#	PR	Scope	Tier
1	#226	Foundation + GitHub Actions (open) — shared plumbing, GHA converter, skill docs (GHA sections), issue template	1
2	pending	GitLab CI — `gitlab.go`, fixture, skill GitLab sections	1
3	pending	Jenkins via API — `jenkins.go`, AST, skill Jenkins sections	1
4	pending	CircleCI — `circleci.go`, orb expansions, skill sections	2
5	pending	Azure DevOps — `azure.go`, task mappings, skill sections	2
6	pending	Bitbucket Pipelines — `bitbucket.go`, pipe mappings, skill sections	2
7	pending	Travis CI — `travis.go`, language defaults, skill sections	3

Priority / tier rationale (based on JetBrains 2024 Developer Ecosystem survey × our code investment × strategic value for TeamCity): GHA + Jenkins + GitLab together cover ~89% of real-world CI usage.

What this branch still contains

The full 7-system implementation, already refined through:

Multiple rounds of Codex automated review (Jenkins `post` on parallel/nested stages, `${env.*}` ordering, CircleCI executor env merge, CircleCI invocation param threading, GitLab include deep-merge + slash-prefix paths, GitHub subpath lookup, duplicate job IDs, Bitbucket stage sequential execution, etc.)
Lint cleanup (`gofmt`, `golangci-lint` clean)
Modern Go (Go 1.26 — `cmp.Or`, `strings.NewReplacer`, `slices.SortFunc`, `strings.SplitSeq`, `maps.Copy`)
Honest output: "⚠ Partial conversion" instead of blanket "✓ Valid YAML"
Bundled `migrate-to-teamcity` skill
Dedicated issue template at https://jb.gg/tc/migrate/issues

Follow-up PRs will cherry-pick each CI's code from this branch and add it on top of the foundation.

Next step

Review and merge #226. Once it lands, PR #2 (GitLab) will be cut off fresh `main` using this branch as the source material.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58b7b038e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5660d2d40f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

chatgpt-codex-connector · 2026-04-13T09:50:47Z

+			taskSteps, taskCache := convertAzureTask(taskRef, step, stepName, result, opts)
+			j.Steps = append(j.Steps, taskSteps...)


Preserve step env when converting Azure task steps

buildAzureJob extracts stepEnv for every Azure step, but in the task branch it appends taskSteps directly without attaching those environment variables. This drops env: for common task forms like Bash@3/CmdLine@2/PowerShell@2, so migrated scripts can run without required tokens/flags and fail at runtime even though the source pipeline works.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-13T09:50:47Z

+	if run, ok := v["run"].(string); ok {
+		return []Step{{ScriptContent: mapCircleCIVars(run)}}, false


Apply CircleCI parameter substitution to run shorthand

The shorthand run path maps variables but skips substituteCircleParams, so commands written as - run: "echo << parameters.msg >>" keep raw << parameters.* >> placeholders in generated script-content. In parameterized jobs this produces invalid commands after migration; this branch should substitute invocation/job params the same way as the map-form run.command path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db5c3b0117

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

chatgpt-codex-connector · 2026-04-13T10:04:24Z

+	if jobsMap, ok := doc["jobs"].(map[string]any); ok {
+		if includes, ok := jobsMap["include"].([]any); ok && len(includes) > 0 {
+			return convertTravisJobMatrix(doc, includes, result)
+		}


Keep default Travis jobs when include entries are present

This early return converts only jobs.include/matrix.include entries and skips the base Travis job matrix derived from top-level keys (for example language + node_js/go versions). In common configs where include adds deploy/lint jobs on top of normal build/test jobs, the generated TeamCity pipeline silently drops the primary jobs and can run only the extras.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-13T10:04:24Z

+		steps, ok := job["steps"].([]any)
+		if !ok {
+			continue
+		}


Emit CircleCI jobs even when steps is omitted

Jobs are skipped entirely when job["steps"] is absent, which drops valid workflow nodes such as type: no-op jobs (or other non-step templates) and leaves downstream dependencies pointing at jobs that were never emitted. This can produce broken execution graphs after migration even though the source CircleCI workflow is valid.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7826181b7d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

chatgpt-codex-connector · 2026-04-13T11:45:52Z

+	if image, ok := doc["image"].(string); ok {
+		globalImage = image
+	} else if imgMap, ok := doc["image"].(map[string]any); ok {
+		if name, ok := imgMap["name"].(string); ok {


Handle GitLab default.image inheritance

The converter only reads doc["image"] for the global runtime image and never inspects default.image, so pipelines that set a shared image under default are migrated without any Docker-image manual setup hint. In those repos, converted jobs can run on agents missing required tooling because the inherited container context is silently dropped.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-13T11:45:52Z

+	if services, ok := doc["services"].([]any); ok && len(services) > 0 {
+		result.ManualSetup = append(result.ManualSetup,
+			fmt.Sprintf("Global services %v → configure as Docker Compose or agent-level services", extractGitLabServiceNames(services)))


Account for GitLab default.services

Global service detection only checks top-level services, so default.services is ignored. When a GitLab pipeline defines shared services (e.g., Postgres/Redis) in default, the migration omits the corresponding manual setup guidance and generated jobs run without those service containers, which can break otherwise-valid test/deploy stages.

Useful? React with 👍 / 👎.

…s, 60+ action transformers