build: Add Makefile; replace inline knit logic with Makefile target in GitHub workflow#1750
build: Add Makefile; replace inline knit logic with Makefile target in GitHub workflow#1750
Conversation
…n GitHub workflow - Add a Makefile for easier local build reproduction - Replace inline knit logic with Makefile target in GitHub workflow - Update CONTRIBUTING.md
18d07cf to
22fd946
Compare
@EugeneTheDev, thank you for pointing this out. While Additionally, is the file counting logic in the current workflow beneficial, or should it be removed? |
|
I generally like the idea of the
That said, knit is a weak example — Someone could make a valid argument that this adds something to maintain — but then again, these shortcuts are opt-in and could simplify some developers' workflow, so I'd vote for adding it. |
Amaneusz
left a comment
There was a problem hiding this comment.
I'm ok with adding this if we’ll reach consensus with other devs.
I personally see myself using Makefile but at the same time I did not have that much issue with "gradle only" approach.
If we proceed with it, we should probably change the knit target and simplify it as Andrey suggested
Rizzen
left a comment
There was a problem hiding this comment.
I’m not convinced make is the right abstraction here. This change adds a Makefile and supporting docs, but most of the targets just wrap simple one-liners. That gives very little benefit while introducing extra indirection and another maintenance surface.
It also brings in a Unix-centric tool requirement. make isn’t equally natural or available on Windows (it typically has to be installed separately), which could reduce accessibility rather than improve local reproducibility.
Given how simple these commands are, it seems clearer and more maintainable to keep them as one-liners in CONTRIBUTING.md instead of introducing make.
- Replace verbose knit generation logic with streamlined `knitAssemble` task.
Add Makefile; replace inline knit logic with Makefile target in GitHub workflow