fix(koog-ktor): rename registerTools parameter to avoid Builder.build() shadowing (#1705)#1721
Open
hxreborn wants to merge 1 commit intoJetBrains:developfrom
Open
fix(koog-ktor): rename registerTools parameter to avoid Builder.build() shadowing (#1705)#1721hxreborn wants to merge 1 commit intoJetBrains:developfrom
hxreborn wants to merge 1 commit intoJetBrains:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
KoogAgentsConfig.registerTools, the lambda parameter was namedbuild. Inside theToolRegistry { }block (wherethisisToolRegistry.Builder), callingbuild()resolves to the member functionBuilder.build()instead of the lambda, because Kotlin member functions always shadow extension-like lambdas. So tools passed through the ktor plugin config never actually got registered.Renamed the parameter from
buildtoblockto avoid the shadowing. It's a lambda param so this is source-compatible.Fixes #1705