fix(embeddings): check HTTP status before deserializing Ollama embedding response#1702
Open
mvanhorn wants to merge 1 commit intoJetBrains:developfrom
Open
fix(embeddings): check HTTP status before deserializing Ollama embedding response#1702mvanhorn wants to merge 1 commit intoJetBrains:developfrom
mvanhorn wants to merge 1 commit intoJetBrains:developfrom
Conversation
…ing response When Ollama returns an error (e.g., model not loaded), the response body doesn't match EmbeddingResponseDTO, causing a JsonDecodingException. This adds the same status check used by the chat method, throwing a clear LLMClientException with the HTTP status and error body instead. Fixes JetBrains#1499
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Ollama returns an error response (e.g., model not loaded, server unavailable),
OllamaClient.embed()attempts to deserialize the error body asEmbeddingResponseDTO, causing aJsonDecodingException. The user sees a serialization stack trace instead of the actual error message from Ollama.This adds an HTTP status check before deserialization, matching the pattern already used by
executeImpl()at line 206 in the same file. On non-success status codes, aLLMClientExceptionis thrown with the HTTP status and Ollama's error body, giving users a clear error message like:instead of a
JsonDecodingExceptionstack trace.Fixes #1499
This contribution was developed with AI assistance (Claude Code).