Core module java rewrite#341
Merged
Merged
Conversation
Ostrzyciel
requested changes
Apr 16, 2025
nk2IsHere
force-pushed
the
core-module-java-rewrite
branch
2 times, most recently
from
db99436 to
48c8eef
Compare
nk2IsHere
force-pushed
the
core-module-java-rewrite
branch
from
3a4ef02 to
9cf0c90
Compare
Ostrzyciel
requested changes
Apr 22, 2025
nk2IsHere
force-pushed
the
core-module-java-rewrite
branch
from
ee447a3 to
5842f05
Compare
nk2IsHere
force-pushed
the
core-module-java-rewrite
branch
from
5842f05 to
70e381c
Compare
Ostrzyciel
requested changes
Apr 22, 2025
Member
Ostrzyciel
left a comment
Ostrzyciel
left a comment
There was a problem hiding this comment.
partial review, continuing
Ostrzyciel
requested changes
Apr 22, 2025
| * Parameters passed to the Jelly encoder. | ||
| * <p> | ||
| * New fields may be added in the future, but always with a default value and in a sequential order. | ||
| * However, it is still recommended to use named arguments when creating this object. |
Member
There was a problem hiding this comment.
This is out of date, I think.
I haven't worked with Java records. Can we add new fields in a backwards-compatible manner? Or would we need explicit constructors for that?
Collaborator
Author
There was a problem hiding this comment.
we need explicit constructors for that
Member
There was a problem hiding this comment.
Then I'm for adding explicit constructors. This will be wordy and awful, I know, but otherwise introducing a new parameter to the constructor would be a breaking change (!!!!) requiring us to bump the version to 4.0.0. That's bad.
Collaborator
Author
There was a problem hiding this comment.
We can use factory methods like you did in scala,
or we can use static Params of(...) in Params (aka "named" constructors) to achieve same effect
Ostrzyciel
requested changes
Apr 22, 2025
nk2IsHere
force-pushed
the
core-module-java-rewrite
branch
from
b3cc9db to
15e354e
Compare
Ostrzyciel
requested changes
Apr 23, 2025
Ostrzyciel
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
core-javaandrdf-protos-javamodules intended to replacecoreandrdf-protos, written in scala to ones written in pure java.This is a part of preparation for
v3.0.0release.Link to repo before breaking changes: v2.10.2
Notable API Changes:
eu.neverblinkis introduced to all new modulesJellyConstants,JellyOptionswithUPPERCASE_NAMINGfor constants replacedConstantsandOptionsJellyConverterFactoryandJellyTranscoderFactoryintroduced to centralise core modules context maintaining.ProtoDecoderchain now depends onProtoHandler<TNode>as a handler of different statement types decoding.ProtoDecodernow does not specify types of Triples and Quads.ProtoEncodernow does not returnIterable<Row>on ingestion, instead aCollection<RdfStreamRow> appendableRowBuffermust be passed through parameters for the purposes of encoded statements collection.