Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes package version management and standardizes target frameworks for all benchmark projects.
- Introduce
Directory.Packages.propsto manage package versions centrally - Remove per-project version attributes and rely on central versions
- Add
Directory.Build.propsunderbenchmarks/to unifyTargetFrameworkandLangVersion
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| benchmarks/Insight.Database.Benchmarks/Insight.Database.Benchmarks.csproj | Removed explicit versions and moved TFM to Directory.Build.props |
| benchmarks/Insight.Database.Benchmarks.Sqlite/Insight.Database.Benchmarks.Sqlite.csproj | Removed explicit version and TFM |
| benchmarks/Insight.Database.Benchmarks.SqlServer/Insight.Database.Benchmarks.SqlServer.csproj | Removed TFM |
| benchmarks/Insight.Database.Benchmarks.Postgres/Insight.Database.Benchmarks.Postgres.csproj | Removed explicit version and TFM |
| benchmarks/Insight.Database.Benchmarks.MySql/Insight.Database.Benchmarks.MySql.csproj | Removed explicit version and TFM |
| benchmarks/Insight.Database.Benchmarks.Models/Insight.Database.Benchmarks.Models.csproj | Removed explicit versions and TFM |
| benchmarks/Directory.Build.props | Added shared TargetFramework and LangVersion |
| Insight.Database.Benchmarks.sln | Added Directory.Packages.props to solution items |
| Directory.Packages.props | New central package version file |
Comments suppressed due to low confidence (1)
benchmarks/Insight.Database.Benchmarks/Insight.Database.Benchmarks.csproj:3
- [nitpick] This project no longer explicitly sets a
TargetFramework(it was previouslynetstandard2.0) and now inheritsnet9.0fromDirectory.Build.props. Please confirm this change is intentional or add an override if a different framework is required.
<ItemGroup>
benchmarks/Insight.Database.Benchmarks/Insight.Database.Benchmarks.csproj
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves our dependencies into centralized package management.
Type of change
Checklist