Update time to fix build failures on rust 1.80.0#134
Merged
JanLikar merged 1 commit intoJanLikar:masterfrom Aug 24, 2024
Merged
Update time to fix build failures on rust 1.80.0#134JanLikar merged 1 commit intoJanLikar:masterfrom
time to fix build failures on rust 1.80.0#134JanLikar merged 1 commit intoJanLikar:masterfrom
Conversation
Rust `1.80.0` introduced a [new trait implementation](rust-lang/rust#99969) which caused builds of [old versions of the `time` crate to fail](rust-lang/rust#127343). Since `cargo clone` depends on one of these old `time` versions, builds with rust `1.80.0` or later fail: ``` error[E0282]: type annotations needed for `Box<_>` --> /home/ethan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | help: consider giving `items` an explicit type, where the placeholders `_` are specified | 83 | let items: Box<_> = format_items | ++++++++ For more information about this error, try `rustc --explain E0282`. error: could not compile `time` (lib) due to 1 previous error ``` Updating to a version of time with this regression fixed, with `cargo update -p time`, fixes the build of `cargo clone`. It would also be helpful to get a new release of `cargo clone` after this is merged, since this is also causing the `cargo clone` package to [fail on NixOS](NixOS/nixpkgs#332957 (comment)).
Owner
|
Thank you, I appreciate it! |
JanLikar
approved these changes
Aug 24, 2024
13 tasks
Owner
|
@eopb I released v1.2.3 and created a PR in nixpkgs. See NixOS/nixpkgs#337058. Thanks again for fixing it, I wasn't even aware of the issue. I figured it was just a problem with CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust
1.80.0introduced a new trait implementation which caused builds of old versions of thetimecrate to fail.Since
cargo clonedepends on one of these oldtimeversions, builds with rust1.80.0or later fail:Updating to a version of time with this regression fixed, with
cargo update -p time, fixes the build ofcargo clone.It would also be helpful to get a new release of
cargo cloneafter this is merged, since this is also causing thecargo clonepackage to fail on NixOS.